chore(runway): cherry-pick chore: cp-7.51.0 faster address checksum (#16926)

[runway-github]

• chore: cp-7.51.0 faster address checksum (chore: cp-7.51.0 faster address checksum #16926) (chore: cp-7.51.0 faster address checksum (#16926) #17174)

Description

This PR is
originally from @Nodonisko from Margelo

This PR uses new faster memoized functions for working with address
checksum.

There is already significant boost in AccountList performance and it
should be even better when MetaMask/core#6054 is
released and also when we fix Blockies Avatars.

Related issues

Fixes: #15560

Manual testing steps

1. Open Account List
2. It should feel faster than before

Screenshots/Recordings

Before

You can set that before then was lot of interrupted work before Account
List modal is even displayed. It takes around ~7s from click to modal to
be actually visible.

After

Here it takes only around ~3s to mount. (still slow but much better than
before)

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and [MetaMask Mobile
  Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).

• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

Co-authored-by: Daniel Suchý suchydan@gmail.com 55bc8a6

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Bug: Address Formatting Refactor Introduces Errors

The refactor of address formatting introduces a potential runtime error and a functional change. toFormattedAddress is called unconditionally with selectedAddress, which can be null or undefined, potentially causing runtime errors. The previous code safely handled this with selectedAddress || ''. Additionally, the logic for determining address formatting changed from !isNonEvmAddress to toFormattedAddress (which uses isEthAddress), potentially leading to incorrect address formatting and balance lookups if the underlying logic differs. The selectedAddress as Hex type cast is also incorrect as toFormattedAddress expects a string.

app/selectors/earnController/earn/index.ts#L158-L200

metamask-mobile/app/selectors/earnController/earn/index.ts

Lines 158 to 200 in 33aa867

	selectLendingMarketsByChainIdAndOutputTokenAddress(earnState);
	const earnTokensData = allTokens.reduce((acc, token) => {
	const experiences: EarnTokenDetails['experiences'] = [];
	const decimalChainId = getDecimalChainId(token.chainId);
	const lendingMarketsForToken =
	lendingMarketsByChainIdAndTokenAddress?.[decimalChainId]?.[
	token.address.toLowerCase()
	] || [];
	const lendingMarketsForOutputToken =
	lendingMarketsByChainIdAndOutputTokenAddress?.[decimalChainId]?.[
	token.address.toLowerCase()
	] || [];
	const pooledStakingVaultForChain =
	pooledStakingPerChain?.[decimalChainId]?.vaultMetadata;
	const pooledStakingVaultAprForChain = parseFloat(
	pooledStakingPerChain?.[decimalChainId]?.vaultApy.apyPercentString,
	).toString();
	const isStakingSupportedChain =
	isSupportedPooledStakingChain(decimalChainId);
	const isLendingToken = lendingMarketsForToken.length > 0;
	const isLendingOutputToken = lendingMarketsForOutputToken.length > 0;
	const isStakingToken =
	token.isETH && !token.isStaked && isStakingSupportedChain;
	const isStakingOutputToken =
	token.isETH && token.isStaked && isStakingSupportedChain;
	const isEarnToken = isStakingToken || isLendingToken;
	const isEarnOutputToken = isStakingOutputToken || isLendingOutputToken;
	if (!isEarnToken && !isEarnOutputToken) {
	return acc;
	}
	// TODO: balance logic, extract to utils then use when we are clear to add token
	const formattedAddress = toFormattedAddress(selectedAddress as Hex);
	const rawAccountBalance = selectedAddress
	? accountsByChainId[token?.chainId as Hex]?.[formattedAddress]?.balance
	: '0';
	const rawStakedAccountBalance = selectedAddress
	? accountsByChainId[token?.chainId as Hex]?.[formattedAddress]
	?.stakedBalance
	: '0';

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tommasini]

We are not cherry picking this work to 7.51.0 only to 7.52.0