chore(runway): cherry-pick chore: cp-7.52.0 match extension implementation of validation/simulation error details #17558
Conversation
…ation of validation/simulation error details (#17518) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Matches the existing implementation of error details in extension. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to Solana swaps 2. Get quote that fails simulation 3. See improved error details ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-runway-bot-deprecated
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
metamaskbot
added
the
release-7.52.0
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
12 similar comments
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
Description
Matches the existing implementation of error details in extension.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. 40e0bd5