Skip to content

Conversation

@tommasini
Copy link
Contributor

@tommasini tommasini commented Aug 7, 2025

Description

This work aims to help PM/QA/Devs skip onboarding and test features, run e2e, and develop. Giving some extra time to everyone and fewer steps needed to get where they want! Calling it "default app start user,".
It supports multiple SRPs, and you need to define a password in your environment variables

The way it works is basically adding environment variables with the desired SRPs and respective login passwords

ADDITIONAL_SRP_1="srp1"
ADDITIONAL_SRP_2="srp2"
ADDITIONAL_SRP_*="srp2"
PREDEFINED_PASSWORD="theoneyouwant"

The logic behind this feature should never trigger in production since it's under the condition of PREDEFINED_PASSSWORD environment variable being defined, which shouldn't never be true outside of a internal testing scope.

Bitrise build: https://app.bitrise.io/build/e361ff45-526b-4a51-bc7d-a97b94cdf29b?tab=artifacts

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Screen.Recording.2025-08-27.at.11.59.59.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Aug 7, 2025
@tommasini tommasini changed the title chore: default app start user, building the vault and exporting it to engine… chore: Default app start user Aug 25, 2025
@tommasini tommasini marked this pull request as ready for review August 25, 2025 22:24
cursor[bot]

This comment was marked as outdated.

@tommasini tommasini marked this pull request as draft August 26, 2025 09:43
@github-actions github-actions bot added size-S and removed size-M labels Aug 26, 2025
@tommasini tommasini added Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 26, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Aug 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 98029b3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6795480e-879b-4e83-9e56-229bba7d9247

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini marked this pull request as ready for review August 26, 2025 22:47
cursor[bot]

This comment was marked as outdated.

cortisiko
cortisiko previously approved these changes Aug 29, 2025
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ffecb39
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2eb93519-73a6-4e6a-a1f6-982ace4f5fea

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ed790ce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3450aaad-55a3-4e34-a0f2-5d32d5347a80

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 741425c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a23a4e1-667f-46f0-9830-8f16f9ab5cf3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini enabled auto-merge September 1, 2025 10:54
@tommasini tommasini added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 1, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.67%. Comparing base (60a26ad) to head (bac18d7).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
app/util/generateSkipOnboardingState.ts 16.66% 18 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18108      +/-   ##
==========================================
+ Coverage   75.60%   75.67%   +0.06%     
==========================================
  Files        3141     3144       +3     
  Lines       73571    73672     +101     
  Branches    12876    12903      +27     
==========================================
+ Hits        55624    55750     +126     
+ Misses      14377    14345      -32     
- Partials     3570     3577       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
35.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@tommasini tommasini added this pull request to the merge queue Sep 1, 2025
Merged via the queue into main with commit aa5e5be Sep 1, 2025
64 of 66 checks passed
@tommasini tommasini deleted the chore/default-app-start-user branch September 1, 2025 11:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 1, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants