Skip to content

Conversation

@brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Sep 2, 2025

Description

Changelog

CHANGELOG entry: Improved Wallet Homepage with left-aligned tabs and smoother full-page scrolling.

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/jira/software/c/projects/DSYS/boards/1888?assignee=62afb43d33a882e2be47c36f&quickFilter=2109&selectedIssue=DSYS-143

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-09-04.at.18.38.11.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested review from a team as code owners September 2, 2025 23:37
@brianacnguyen brianacnguyen marked this pull request as draft September 2, 2025 23:37
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Sep 2, 2025
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-M and removed size-XL labels Sep 3, 2025
@brianacnguyen brianacnguyen self-assigned this Sep 4, 2025
@brianacnguyen brianacnguyen changed the title DRAFT: Feat/new tabs demo chore: Updated Wallet homepage to use custom tabs and enable page-level scroll behavior Sep 8, 2025
@brianacnguyen brianacnguyen marked this pull request as ready for review September 8, 2025 15:34
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a557452
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/827cb275-55cd-4b55-b96d-2c76f2b09596

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.15%. Comparing base (e624efc) to head (09a8048).
⚠️ Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/Wallet/index.tsx 50.00% 3 Missing and 5 partials ⚠️
...library/components-temp/Tabs/TabsList/TabsList.tsx 61.53% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19141      +/-   ##
==========================================
+ Coverage   76.03%   76.15%   +0.12%     
==========================================
  Files        3201     3227      +26     
  Lines       75664    76591     +927     
  Branches    13441    13670     +229     
==========================================
+ Hits        57532    58329     +797     
- Misses      14409    14497      +88     
- Partials     3723     3765      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gambinish
gambinish previously approved these changes Sep 11, 2025
@gambinish gambinish disabled auto-merge September 11, 2025 16:48
@sonarqubecloud
Copy link

@gambinish gambinish enabled auto-merge September 11, 2025 17:52
@brianacnguyen brianacnguyen added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit 962f411 Sep 11, 2025
68 checks passed
@brianacnguyen brianacnguyen deleted the feat/new-tabs-demo branch September 11, 2025 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-L team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants