-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: animation on lock screen, replace by static fox more loader #19342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
…be registered after the app state already changed, not triggering unlockKeyrings
|
|
|
||
| // Trigger biometrics immediately if app is already active | ||
| // This handles cases where component mounts during rapid background/foreground cycles | ||
| if (AppState.currentState === 'active') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to note that this is the patch
Cal-L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vinnyhoward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix and clean up! LGTM



Description
Problem:
LockScreen component only triggered biometrics when AppState changed
During rapid background/foreground cycles during login, the component could mount when the app was already in 'active' state
Since no AppState change occurs (app is already active), the listener never fires
User sees FoxLoader indefinitely without biometrics being triggered
Solution:
Simplified the LockScreen component by replacing laggy Lottie animations with a static FoxLoader component to improve performance and user experience.
Changes Made
Impact
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-09-05.at.18.28.28.mov
Pre-merge author checklist
Pre-merge reviewer checklist