Skip to content

feat: TAT-1659: Updated perps full screen modal announcement #19716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Matt561 merged 3 commits into from
Sep 14, 2025
Merged

feat: TAT-1659: Updated perps full screen modal announcement #19716

Matt561 merged 3 commits into from
Sep 14, 2025
+31 −39

Conversation

@Matt561
Copy link
Contributor

@Matt561 Matt561 commented Sep 13, 2025 •
edited
Loading

Description

Updates the Perps fullscreen modal announcement

Changelog

CHANGELOG entry: updated perps full screen modal announcement

Related issues

Fixes: TAT-1659: Update full page modal announcement

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Matt561 Matt561 added No QA Needed Apply this label when your PR does not need any QA effort. team-perps Perps team labels Sep 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 marked this pull request as ready for review September 13, 2025 22:00
@Matt561 Matt561 requested a review from a team as a code owner September 13, 2025 22:00
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 13, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@Matt561 Matt561 added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E labels Sep 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 14, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
70.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Matt561 Matt561 enabled auto-merge September 14, 2025 17:52
gambinish
gambinish approved these changes Sep 14, 2025
View reviewed changes
Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested on Samsung Galaxy S23 Ultra

@Matt561 Matt561 added this pull request to the merge queue Sep 14, 2025
Merged via the queue into main with commit 9b10fe3 Sep 14, 2025
98 of 99 checks passed
@Matt561 Matt561 deleted the feat/tat-1659-update-full-page-modal-announcement branch September 14, 2025 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-earn team-perps Perps team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Matt561 @gambinish @metamaskbot