Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Sep 15, 2025

Description

Minimum deposit validation is incorrectly firing as it's also checking the token amount, rather than just the pending input amount.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #5819

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner September 15, 2025 09:29
@matthewwalsh0 matthewwalsh0 added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Sep 15, 2025
@sonarqubecloud
Copy link

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit b5784be Sep 15, 2025
165 of 167 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/perps-deposit-minimum branch September 15, 2025 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants