Skip to content

Conversation

@ieow
Copy link
Contributor

@ieow ieow commented Oct 31, 2025

Description

Remove not needed workaround for change password e2e test issue

Changelog

CHANGELOG entry: null

Related issues

Fixes:
#16758

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Remove iOS CI-specific workaround from the change-password flow in the delete wallet E2E test.

  • E2E tests:
    • Remove iOS CI-specific workaround in e2e/specs/settings/delete-wallet.spec.ts that tapped TabBarComponent.tapWallet() after changing password.

Written by Cursor Bugbot for commit 6e9f931. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Oct 31, 2025
@ieow ieow marked this pull request as ready for review October 31, 2025 08:40
@ieow ieow changed the title fix: remove workaround on e2e fix: remove not needed workaround on e2e Nov 3, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Nov 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Nov 3, 2025
@ieow ieow added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 2bae3fa Nov 3, 2025
152 of 154 checks passed
@ieow ieow deleted the fix/change-password-ios-e2e branch November 3, 2025 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-XS team-onboarding Onboarding team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants