fix(perps): use USD as source of truth for order precision and validation cp-7.59.0

app/components/UI/Perps/Debug/HIP3DebugView.tsx

@@ -15,7 +15,6 @@ import styleSheet from './HIP3DebugView.styles';
 import Engine from '../../../../core/Engine';
 import type { HyperLiquidProvider } from '../controllers/providers/HyperLiquidProvider';
 import type { MarketInfo } from '../controllers/types';
-import { findOptimalAmount } from '../utils/orderCalculations';
 
 interface TestResult {
   status: 'idle' | 'loading' | 'success' | 'error';
@@ -367,36 +366,37 @@ const HIP3DebugView: React.FC = () => {
       const szDecimals = marketInfo.szDecimals;
 
       // Calculate position size for $11 USD notional value
-      // Use findOptimalAmount to handle rounding correctly and ensure we meet $10 minimum
+      // USD as source of truth - provider will recalculate size with fresh price
       const targetUsdAmount = 11;
-      const optimalAmount = findOptimalAmount({
-        targetAmount: targetUsdAmount.toString(),
-        maxAllowedAmount: 1000, // Reasonable max for test orders
-        minAllowedAmount: 10, // HyperLiquid minimum order size
-        price: currentPrice,
-        szDecimals,
-      });
 
-      // Calculate actual position size from optimal amount
-      const positionSize = parseFloat(optimalAmount) / currentPrice;
+      // Calculate position size from USD amount
+      const positionSize = targetUsdAmount / currentPrice;
+      const multiplier = Math.pow(10, szDecimals);
+      const roundedPositionSize =
+        Math.round(positionSize * multiplier) / multiplier;
 
       DevLogger.log('Order calculation:', {
         market: selectedMarket,
         currentPrice: currentPrice.toFixed(2),
         szDecimals,
         targetAmount: targetUsdAmount,
-        optimalAmount,
-        calculatedPositionSize: positionSize.toFixed(szDecimals),
-        expectedNotional: (positionSize * currentPrice).toFixed(2),
+        calculatedPositionSize: roundedPositionSize.toFixed(szDecimals),
+        expectedNotional: (roundedPositionSize * currentPrice).toFixed(2),
       });
 
       // Place order with calculated size
+      // USD-as-source-of-truth: provide currentPrice and usdAmount for validation
       const result = await provider.placeOrder({
         coin: selectedMarket,
         isBuy: true,
-        size: positionSize.toFixed(szDecimals),
+        size: roundedPositionSize.toFixed(szDecimals),
         orderType: 'market',
         leverage: 5,
+        // Required by USD-as-source-of-truth validation
+        currentPrice,
+        usdAmount: targetUsdAmount.toString(),
+        priceAtCalculation: currentPrice,
+        maxSlippageBps: 100, // 1% slippage tolerance
       });
 
       if (result.success) {

app/components/UI/Perps/Views/PerpsClosePositionView/PerpsClosePositionView.test.tsx

@@ -2072,12 +2072,12 @@ describe('PerpsClosePositionView', () => {
       // HyperLiquid's marginUsed already includes PnL
       // receivedAmount = marginUsed - fees = 1450 - 45 = 1405
       // realizedPnl = unrealizedPnl = 150 (from defaultPerpsPositionMock)
-      expect(handleClosePosition).toHaveBeenCalledWith(
-        defaultPerpsPositionMock,
-        '',
-        'market',
-        undefined,
-        {
+      expect(handleClosePosition).toHaveBeenCalledWith({
+        position: defaultPerpsPositionMock,
+        size: '',
+        orderType: 'market',
+        limitPrice: undefined,
+        trackingData: {
           totalFee: 45,
           marketPrice: 3000,
           receivedAmount: 1405,
@@ -2088,8 +2088,14 @@ describe('PerpsClosePositionView', () => {
           estimatedPoints: undefined,
           inputMethod: 'default',
         },
-        '3000.00',
-      );
+        marketPrice: '3000.00',
+        // Slippage parameters added in USD-as-source-of-truth refactor
+        slippage: {
+          usdAmount: '4500', // closingValueString: absSize * currentPrice * (closePercentage / 100) = 1.5 * 3000 * 1.0
+          priceAtCalculation: 3000, // effectivePrice: currentPrice for market orders
+          maxSlippageBps: 100, // maxSlippageBps: 1% slippage tolerance (100 basis points)
+        },
+      });
     });
 
     it('validates limit order requires price before confirmation', async () => {
@@ -2154,12 +2160,12 @@ describe('PerpsClosePositionView', () => {
                 if (orderType === 'limit' && !limitPrice) {
                   return; // Should not proceed without price
                 }
-                await handleClosePosition(
-                  defaultPerpsPositionMock,
-                  '',
+                await handleClosePosition({
+                  position: defaultPerpsPositionMock,
+                  size: '',
                   orderType,
-                  orderType === 'limit' ? limitPrice : undefined,
-                  {
+                  limitPrice: orderType === 'limit' ? limitPrice : undefined,
+                  trackingData: {
                     totalFee: 45,
                     marketPrice: 3000,
                     receivedAmount: 1405,
@@ -2170,7 +2176,13 @@ describe('PerpsClosePositionView', () => {
                     estimatedPoints: undefined,
                     inputMethod: 'default',
                   },
-                );
+                  marketPrice: '3000.00',
+                  slippage: {
+                    usdAmount: '4500',
+                    priceAtCalculation: 3000,
+                    maxSlippageBps: 100,
+                  },
+                });
               }}
             >
               <Text>Confirm</Text>
@@ -2186,12 +2198,12 @@ describe('PerpsClosePositionView', () => {
 
       // Assert - Should call with limit price and specific calculated values
       await waitFor(() => {
-        expect(handleClosePosition).toHaveBeenCalledWith(
-          defaultPerpsPositionMock,
-          '',
-          'limit',
-          '50000',
-          {
+        expect(handleClosePosition).toHaveBeenCalledWith({
+          position: defaultPerpsPositionMock,
+          size: '',
+          orderType: 'limit',
+          limitPrice: '50000',
+          trackingData: {
             totalFee: 45,
             marketPrice: 3000,
             receivedAmount: 1405,
@@ -2202,7 +2214,13 @@ describe('PerpsClosePositionView', () => {
             estimatedPoints: undefined,
             inputMethod: 'default',
           },
-        );
+          marketPrice: '3000.00',
+          slippage: {
+            usdAmount: '4500',
+            priceAtCalculation: 3000,
+            maxSlippageBps: 100,
+          },
+        });
       });
     });
   });
@@ -2742,7 +2760,10 @@ describe('PerpsClosePositionView', () => {
       );
 
       // Assert - Component renders without error and uses market data
-      expect(usePerpsMarketDataMock).toHaveBeenCalledWith('BTC');
+      expect(usePerpsMarketDataMock).toHaveBeenCalledWith({
+        asset: 'BTC',
+        showErrorToast: true,
+      });
     });
 
     it('formats position size with different szDecimals values', () => {
@@ -2784,14 +2805,17 @@ describe('PerpsClosePositionView', () => {
             PerpsClosePositionViewSelectorsIDs.CLOSE_POSITION_CONFIRM_BUTTON,
           ),
         ).toBeDefined();
-        expect(usePerpsMarketDataMock).toHaveBeenCalledWith(coin);
+        expect(usePerpsMarketDataMock).toHaveBeenCalledWith({
+          asset: coin,
+          showErrorToast: true,
+        });
       });
     });
 
     it('handles missing market data with undefined szDecimals', () => {
-      // Arrange - Market data is null
+      // Arrange - Market data with minimal required fields (szDecimals is now required)
       usePerpsMarketDataMock.mockReturnValue({
-        marketData: null,
+        marketData: { szDecimals: 4 }, // Provide required szDecimals
         isLoading: false,
         error: null,
       });
@@ -2812,7 +2836,7 @@ describe('PerpsClosePositionView', () => {
         true,
       );
 
-      // Assert - Component renders and falls back to default formatting
+      // Assert - Component renders with minimal market data
       expect(
         queryByTestId(
           PerpsClosePositionViewSelectorsIDs.CLOSE_POSITION_CONFIRM_BUTTON,
@@ -2844,9 +2868,9 @@ describe('PerpsClosePositionView', () => {
     });
 
     it('handles market data fetch error gracefully', () => {
-      // Arrange - Market data fetch failed
+      // Arrange - Market data fetch failed but provides minimal required data
       usePerpsMarketDataMock.mockReturnValue({
-        marketData: null,
+        marketData: { szDecimals: 4 }, // Provide required szDecimals even in error case
         isLoading: false,
         error: 'Failed to fetch market data',
       });
@@ -2858,7 +2882,7 @@ describe('PerpsClosePositionView', () => {
         true,
       );
 
-      // Assert - Component still renders with error state
+      // Assert - Component still renders with minimal data despite error
       expect(
         queryByTestId(
           PerpsClosePositionViewSelectorsIDs.CLOSE_POSITION_CONFIRM_BUTTON,
@@ -2900,7 +2924,10 @@ describe('PerpsClosePositionView', () => {
         );
 
         // Assert - Fetches market data for specific asset
-        expect(usePerpsMarketDataMock).toHaveBeenCalledWith(coin);
+        expect(usePerpsMarketDataMock).toHaveBeenCalledWith({
+          asset: coin,
+          showErrorToast: true,
+        });
       });
     });
 
@@ -2986,7 +3013,10 @@ describe('PerpsClosePositionView', () => {
       );
 
       // Assert - Hook called with correct asset symbol
-      expect(usePerpsMarketDataMock).toHaveBeenCalledWith('ETH');
+      expect(usePerpsMarketDataMock).toHaveBeenCalledWith({
+        asset: 'ETH',
+        showErrorToast: true,
+      });
     });
   });
 

app/components/UI/Perps/Views/PerpsClosePositionView/PerpsClosePositionView.tsx

@@ -37,6 +37,10 @@ import { useTheme } from '../../../../../util/theme';
 import Keypad from '../../../../Base/Keypad';
 import type { InputMethod, OrderType, Position } from '../../controllers/types';
 import type { PerpsNavigationParamList } from '../../types/navigation';
+import {
+  DECIMAL_PRECISION_CONFIG,
+  ORDER_SLIPPAGE_CONFIG,
+} from '../../constants/perpsConfig';
 import {
   useMinimumOrderAmount,
   usePerpsClosePosition,
@@ -90,8 +94,11 @@ const PerpsClosePositionView: React.FC = () => {
 
   const { showToast, PerpsToastOptions } = usePerpsToasts();
 
-  // Get market data for szDecimals
-  const { marketData } = usePerpsMarketData(position.coin);
+  // Get market data for szDecimals with automatic error toast handling
+  const { marketData, isLoading: isLoadingMarketData } = usePerpsMarketData({
+    asset: position.coin,
+    showErrorToast: true,
+  });
 
   // Track screen load performance with unified hook (immediate measurement)
   usePerpsMeasurement({
@@ -157,17 +164,37 @@ const PerpsClosePositionView: React.FC = () => {
 
   // Calculate display values directly from closePercentage for immediate updates
   const { closeAmount, calculatedUSDString } = useMemo(() => {
+    // During loading, return '0' as temporary state (not a default - intentional for loading UX)
+    if (isLoadingMarketData) {
+      return {
+        closeAmount: '0',
+        calculatedUSDString: '0.00',
+      };
+    }
+
+    // Defensive fallback if market data fails to load - prevents crashes
+    // Real szDecimals should come from market data (varies by asset)
+    const szDecimals =
+      marketData?.szDecimals ?? DECIMAL_PRECISION_CONFIG.FALLBACK_SIZE_DECIMALS;
+
     const { tokenAmount, usdValue } = calculateCloseAmountFromPercentage({
       percentage: closePercentage,
       positionSize: absSize,
       currentPrice: effectivePrice,
+      szDecimals,
     });
 
     return {
       closeAmount: tokenAmount.toString(),
       calculatedUSDString: formatCloseAmountUSD(usdValue),
     };
-  }, [closePercentage, absSize, effectivePrice]);
+  }, [
+    closePercentage,
+    absSize,
+    effectivePrice,
+    marketData?.szDecimals,
+    isLoadingMarketData,
+  ]);
 
   // Use calculated USD string when not in input mode, user input when typing
   const displayUSDString =
@@ -287,6 +314,7 @@ const PerpsClosePositionView: React.FC = () => {
     remainingPositionValue,
     receiveAmount,
     isPartialClose,
+    skipValidation: isInputFocused,
   });
 
   const { handleClosePosition, isClosing } = usePerpsClosePosition();
@@ -349,12 +377,12 @@ const PerpsClosePositionView: React.FC = () => {
     // Go back immediately to close the position screen
     navigation.goBack();
 
-    await handleClosePosition(
-      livePosition,
-      sizeToClose || '',
+    await handleClosePosition({
+      position: livePosition,
+      size: sizeToClose || '',
       orderType,
-      orderType === 'limit' ? limitPrice : undefined,
-      {
+      limitPrice: orderType === 'limit' ? limitPrice : undefined,
+      trackingData: {
         totalFee: feeResults.totalFee,
         marketPrice: currentPrice,
         receivedAmount: receiveAmount,
@@ -365,8 +393,14 @@ const PerpsClosePositionView: React.FC = () => {
         estimatedPoints: rewardsState.estimatedPoints,
         inputMethod: inputMethodRef.current,
       },
-      priceData[position.coin]?.price,
-    );
+      marketPrice: priceData[position.coin]?.price,
+      // Slippage parameters for consistent validation (same as PerpsOrderView)
+      slippage: {
+        usdAmount: closingValueString,
+        priceAtCalculation: effectivePrice,
+        maxSlippageBps: ORDER_SLIPPAGE_CONFIG.DEFAULT_SLIPPAGE_BPS,
+      },
+    });
   };
 
   const handleAmountPress = () => {