Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Nov 10, 2025

Description

This PR enables back native token send.

As it stated in the previous automated flaky test thread here and the logs, send native spec was failing. However if you look at the logs - this is not entirely related as there is a detox crash.

I ran these tests over and over on local but I couldn't encoutner the issue once, hence we are enabling it back.

Screen.Recording.2025-11-10.at.08.50.37.mov

Update 1

We still encounter the issues in the CI - Ola had a look but no chance. Hence we are disabling this 50% test rest looks good.

Update 2

It appears the issues are because of % text. I changed e2e test to lookup component test ids instead of text and it worked.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #22135

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds testIDs to percentage buttons and updates send flow e2e selectors to target them by ID.

  • UI:
    • Add testID to percentage buttons in app/components/Views/confirmations/components/edit-amount-keyboard/edit-amount-keyboard.tsx as percentage-button-<value>.
  • E2E Tests:
    • Update e2e/pages/Send/RedesignedSendView.ts to select 50% and Max via getElementByID('percentage-button-50'|'percentage-button-100') instead of text.
    • Keep send native token spec logic the same while interacting with the new IDs.

Written by Cursor Bugbot for commit 505718b. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 10, 2025
matthewwalsh0
matthewwalsh0 previously approved these changes Nov 10, 2025
cryptotavares
cryptotavares previously approved these changes Nov 10, 2025
@OGPoyraz OGPoyraz enabled auto-merge November 11, 2025 10:17
@sonarqubecloud
Copy link

@OGPoyraz OGPoyraz added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit 249ca67 Nov 12, 2025
86 checks passed
@OGPoyraz OGPoyraz deleted the ogp/22135 branch November 12, 2025 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove send native token from quarantine

7 participants