-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
test: Revert disabled send tests #22374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
previously approved these changes
Nov 10, 2025
cryptotavares
previously approved these changes
Nov 10, 2025
e6973f6
dan437
approved these changes
Nov 11, 2025
cmd-ob
approved these changes
Nov 11, 2025
cryptotavares
approved these changes
Nov 11, 2025
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.60.0
Issue or pull request that will be included in release 7.60.0
size-XS
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
This PR enables back native token send.
As it stated in the previous automated flaky test thread here and the logs, send native spec was failing. However if you look at the logs - this is not entirely related as there is a detox crash.
I ran these tests over and over on local but I couldn't encoutner the issue once, hence we are enabling it back.
Screen.Recording.2025-11-10.at.08.50.37.mov
Update 1
We still encounter the issues in the CI - Ola had a look but no chance. Hence we are disabling this
50%test rest looks good.Update 2
It appears the issues are because of
%text. I changed e2e test to lookup component test ids instead of text and it worked.Changelog
CHANGELOG entry: null
Related issues
Fixes: #22135
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds testIDs to percentage buttons and updates send flow e2e selectors to target them by ID.
testIDto percentage buttons inapp/components/Views/confirmations/components/edit-amount-keyboard/edit-amount-keyboard.tsxaspercentage-button-<value>.e2e/pages/Send/RedesignedSendView.tsto select50%andMaxviagetElementByID('percentage-button-50'|'percentage-button-100')instead of text.Written by Cursor Bugbot for commit 505718b. This will update automatically on new commits. Configure here.