fix: cp-7.60.0 Generate correct blockchain explorer urls on bridge txs

[GeorgeGkas]

Description

Fix an issue where the blockchain explorer urls were not generated successfully when bridging assets.

Changelog

CHANGELOG entry: Generate correct blockchain explorer URLs when bridging assets

Related issues

Fixes: #23171

Manual testing steps

Ensure that the correct blockchain URLs are generated when visiting the transaction
details screen after bridging/swapping assets. 

Also ensure that the correct URLs are also generated for old bridge/swaps transactions (no regressions).

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Corrects multichain block explorer URL generation for bridge transactions with proper EVM/non-EVM handling and comprehensive tests.

• Bridge Hook (useMultichainBlockExplorerTxUrl):
  • Uses useBlockExplorer to resolve EVM explorer base URLs via getEvmBlockExplorerUrl with fallback to getEtherscanBaseUrl.
  • Builds EVM tx links with etherscan-link.createCustomExplorerLink.
  • Keeps non-EVM (e.g., Solana) URLs via getTransactionUrl; derives explorer name from URL or useBlockExplorer.
  • Derives explorerName, chainName, and networkImageSource consistently (EVM via CAIP/hex; non-EVM via config).
• Hook Tests (useMultichainBlockExplorerTxUrl.test.tsx):
  • Add extensive coverage for parameter validation, EVM/non-EVM paths, fallback logic, explorer name resolution, network image sourcing, and custom network configs.
  • Mocks external utilities (etherscan-link, useBlockExplorer, getEtherscanBaseUrl, network utils).
• Block Explorer Modal Test (BlockExplorersModal.test.tsx):
  • Adjust expectations to show one Etherscan and one Optimistic button instead of two Etherscan.
• useBlockExplorer:
  • Exposes getEvmBlockExplorerUrl in the returned API.

^{Written by Cursor Bugbot for commit fe97a35. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeTrade, SmokeConfirmationsRedesigned
• Risk Level: medium
• AI Confidence: 85%

click to see 🤖 AI reasoning details

These changes refactor how block explorer URLs are generated for multichain transactions, specifically in the Bridge functionality. The changes consolidate block explorer logic from a Swaps-specific utility to a shared hook.

Key impacts:

1. SmokeTrade: The Bridge functionality (part of trade/swap features) is directly affected. The BlockExplorersModal and TransactionDetails components that show block explorer links for bridge transactions use the modified hook. The test file bridge-action-smoke.spec.ts is tagged with SmokeTrade.

2. SmokeConfirmationsRedesigned: The transaction-details-summary component in confirmations uses the useMultichainBlockExplorerTxUrl hook, so confirmation flows that display block explorer links could be affected by these changes.

Why medium risk:

• This is a refactoring with extensive test coverage updates
• The logic change is primarily moving from one hook implementation to another with similar functionality
• Block explorer URL generation is user-facing and important for transaction verification
• The tests show behavioral changes (expecting different explorer names), indicating functional changes beyond simple refactoring

Why not running more tags:

• The changes are localized to block explorer URL generation, not core wallet, network switching, or accounts
• The hook usage is primarily in Bridge and confirmations contexts
• No changes to critical paths like Engine, Controllers, or framework
• No changes to permission systems, assets display, or other major features

Confidence: 85% - The changes are well-scoped and the affected components are clear from the code analysis. The test coverage is comprehensive. However, there's a slight uncertainty about whether other transaction viewing paths might be indirectly affected.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud