Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SASS] Application broken since v.3.3 #120

Closed
brunolemos opened this issue Oct 1, 2015 · 22 comments
Closed

[SASS] Application broken since v.3.3 #120

brunolemos opened this issue Oct 1, 2015 · 22 comments
Labels

Comments

@brunolemos
Copy link
Contributor

I'm using SASS (not SCSS) and having this error on all files that has an import:

   While processing files with fourseven:scss (for target web.browser):
   /main.sass: Scss compiler error: invalid top-level expression

Or this:

   /client/templates/components/header/header.sass: Scss compiler error: top-level @import directive must be
   terminated by ';'

It seems that it's trying to compile my .sass as an .scss.

REPRODUCTION:

main.sass

@import "teste"

_teste.sass THIS IS NOT WORKING ANYMORE

body
  background: red

_teste.sass this works, but shouldn't because it's a .sass

body {
  background: red;
}
@brunolemos
Copy link
Contributor Author

Current workaround: downgrade to v3.2.0, which works fine:

meteor add fourseven:scss@=3.2.0

@sebakerckhof
Copy link
Collaborator

Fixed in master, will be published soon

@brunolemos
Copy link
Contributor Author

As it was not fixed, I created a pull request adding a unit test that shows my problem.

@sebakerckhof
Copy link
Collaborator

Ok, this seems like problem with node-sass, since indentedSyntax is set to true for the sass file, but still it treats the imported file as scss-style.

@sebakerckhof
Copy link
Collaborator

sass/node-sass#1192

@sebakerckhof
Copy link
Collaborator

I'll reopen till this is fixed in node-sass

@sebakerckhof sebakerckhof reopened this Oct 3, 2015
@fourseven
Copy link
Collaborator

Hi @brunolemos - thanks for the test, this issue still exists in node-sass – so follow that and we'll have this meteor package fixed once it's fixed upstream (the master branch here with your tests has the sass test disabled because of it).

@matfin
Copy link

matfin commented Oct 29, 2015

Just added this to a new sample meteor app I am working on and the issue is still there. I am using version 3.4.1 and still getting the same issue as reported in
#150

If you want to see what is happening you can clone the repository https://github.com/matfin/gfmtest

I am using Meteor 1.2.1

@sebakerckhof
Copy link
Collaborator

Yes, it's still not fixed in libsass

@karldanninger
Copy link

+1

@sebakerckhof
Copy link
Collaborator

From sass/node-sass#1192:

So for importing *.sass files we have to wait a patch.
You guys can covert all sass to scss in one command
sass-convert -R -F sass -T scss .

Since the indented syntax doesn't seem to be a priority for libsass, this might be a solution for some of you.

@brunolemos
Copy link
Contributor Author

I use jade and coffeescript in my projects, so it's consistent to use sass (all indented syntax).
I'll keep using v3.2.0 and wait for a fix (or search for an alternative solution).

@brunolemos brunolemos changed the title [SASS] Application broken on v.3.3.3_1 [SASS] Application broken since v.3.3 Nov 19, 2015
@karldanninger
Copy link

Booo 😿 would like to see this fixed eventually

@rista404
Copy link

If this helps, I get a similar error message:

=> Errors prevented startup:

   While processing files with fourseven:scss (for target web.browser):
   /client/stylesheets/style.sass: Scss compiler error: @import directive requires a url or quoted path


=> Your application has errors. Waiting for file change.

This was happening from 3.3.3 as I recall, and I am using 3.2.0 since then.
I hope this will be fixed eventually.

Cheers!

egladman added a commit to egladman/meteor-normalize.scss that referenced this issue Dec 24, 2015
lowered version because of known [bug](Meteor-Community-Packages/meteor-scss#120) with fourseven/meteor-scss
@andersr
Copy link

andersr commented Jan 11, 2016

It appears that compiling of .sass files still is not working (due to the upstream issue) However, it is not clear from the ReadMe that this is the case and I just spent the last couple hours trying to troubleshoot this until I discovered this issue. Had I known, I would have just gone with .scss right away.

It would be great if a note could be added to the ReadMe that explains that there may be issues with compiling of .sass files.

@calvinfu1128
Copy link

compiling sass fails, downgraded to v3.2 as work around at the moment

lu40 pushed a commit to Openki/Openki that referenced this issue May 28, 2016
as indented-syntax compilation is broken in the latest
version of fourseven:meteor-scss is broken
(Meteor-Community-Packages/meteor-scss#120) but
needed as a dependence for the latest version of
reywood:bootstrap3-sass, so the bootstrap-reference does
not rely on the build process
(englue/meteor-bootstrap3-sass#32)
a switch to the scss syntax was necessary.
@KaizenCris
Copy link

Same issue
In the end I downgraded from 3.8.0_1 to 3.2.0. Are there any plans to fix the .sass import?

@exequiel09
Copy link

Same Issue.

@theosp
Copy link

theosp commented Oct 6, 2016

Check my comment here: #220 (comment)

@Fauphi
Copy link

Fauphi commented Jan 19, 2017

Looks like you cannot install v3.2.0 of fourseven:scss anymore.

Cannot download "https://github.com/sass/node-sass/releases/download/v3.2.0/darwin-x64-46_binding.node": HTTP error 404 Not Found

Any workarounds for that?
I'm on OSX 10.12.2

@sebakerckhof
Copy link
Collaborator

I'll close this issue since it doesn't seem likely node-sass will fix the support for the older sass syntax, since it's considered deprecated. So there's not much we can do about it.

@smeijer
Copy link

smeijer commented Jul 14, 2019

Had this error after adding Bulma,

meteor add fourseven:scss
meteor npm install bulma

client/main.scss

@charset "utf-8";
@import "../node_modules/bulma/bulma.sass";

Is there any known way to get this package working with Bulma?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests