Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indented/sass format seems to be supported? #297

Closed
edemaine opened this issue Nov 17, 2020 · 4 comments
Closed

Indented/sass format seems to be supported? #297

edemaine opened this issue Nov 17, 2020 · 4 comments

Comments

@edemaine
Copy link

I am confused by this statement in the README:

Note that due to a limitation in libsass, there is no support for indented sass syntax. This syntax is deprecated and will likely not ever get supported

I just tried using an indented-format .sass file in my Meteor project, and it worked fine (other than minor bugs in the libsass implementation). Is it possible that this sentence is out of date?

Also, as far as I can tell, the indented/sass syntax is not deprecated. I understand that libsass is deprecated, but libsass does support indented/sass syntax (with some minor bugs).

meteor version: 1.11.1

fourseven:scss version: 4.12.0

@sebakerckhof
Copy link
Collaborator

sebakerckhof commented Nov 18, 2020

The problem is that it doesn't work together with a custom importer (like fourseven:scss has): sass/node-sass#1192 . So imports of indented-syntax will fail.

You are right though that indented syntax is not deprecated, that was a misunderstanding from my side.
However, since libsass is deprecated, I'm working on a version with dart-sass which should fix:

Unfortunately, I ran into a dart-sass bug which is blocking for a release at the moment: sass/dart-sass#1138

@edemaine
Copy link
Author

Ah, OK, so indented sass works "at the top level" (imported from a js file, for example), but not imported from sass or scss. That makes more sense. Do you want to edit the README to document this current state better, or should I submit a PR?

Looking forward to the dart-sass port! Looks like the bug is being processed at least...

@sebakerckhof
Copy link
Collaborator

Ah yes, I intended to update the readme and then got distracted 5 seconds after 😅. It's changed now. Thanks for the heads up.

@edemaine
Copy link
Author

Thanks for fixing the README, and for the quick responses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants