-
Notifications
You must be signed in to change notification settings - Fork 200
Recommended value for member-ordering rule is pointless #341
Comments
Actually, over 10 of the rules give me linting errors because they expect arrays when the value in the recommended is "true" or "false" |
@tommck I think most of those are simply due to the schema not allowing an array or a boolean at the same time. It's perfectly valid to disable an option with just a However for some options just a |
Do any of you have a preferred recommended default value? @tommck which other rules have invalid default parameters? I am not linting the file, so whether or not you get linting errors depends I guess on what your linting tool and linting rules are. |
If anyone wants to make a proposed default value then just edit line 143 of this file: https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/additional_rule_metadata.json I'll accept the pull request that automatically is sent when you click save :) |
I set the default to [true, { "order": "fields-first" }] Feel free to change this! |
The
recommended_ruleset.js
includes a"member-ordering": true
rule which in that form doesn't actually do anything.See the documentation.
The text was updated successfully, but these errors were encountered: