Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Again audit rules that have already been added in TSLint #400

Closed
JoshuaKGoldberg opened this issue Oct 30, 2017 · 1 comment
Closed

Again audit rules that have already been added in TSLint #400

JoshuaKGoldberg opened this issue Oct 30, 2017 · 1 comment
Milestone

Comments

@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Oct 30, 2017

If they're in TSLint proper, remove them from the README.md & give a warning in the file for a version or two instead of checking the rule (before removing the file)?

@JoshuaKGoldberg
Copy link
Author

JoshuaKGoldberg commented Dec 6, 2017

Scrolling through file lists and READMEs...

Rules to remove:

  • function-name: superseded by tslint's variable-name
  • missing-jsdoc: superseded by tslint's file-header
  • no-duplicate-case: superseded by tslint's no-duplicate-switch-case
  • no-empty-interfaces: superseded by tslint's no-empty-interface
  • no-reserved-keywords: superseded by tslint's no-reserved-keywords
  • no-unnecessary-field-initialization: superseded by tslint's no-unnecessary-initializer
  • prefer-array-literal: superseded by tslint's array-type
  • prefer-type-cast: superseded by tslint's no-angle-bracket-type-assertion
  • promise-must-complete: superseded by tslint's no-floating-promises
  • react-tsx-curly-spacing: superseded by tslint-react's jsx-curly-spacing
  • valid-typeof: superseded by tslint's typeof-compare, which was then superseded by the TS compiler

@HamletDRC HamletDRC added this to the 5.0.2 milestone Dec 18, 2017
JoshuaKGoldberg pushed a commit that referenced this issue Oct 15, 2018
JoshuaKGoldberg pushed a commit that referenced this issue Oct 23, 2018
* Marked missing-jsdoc as deprecated

Continues #400.

* Finished removing unecessary (placating missing-jsdoc) JSDocs

Fixes #557

* Added recommended_ruleset.js removal

* Really disabled missing-jsdoc

* Yup, re-ran auto-updating tasks locally

* Fixed informativeDocsRule post-merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants