-
Notifications
You must be signed in to change notification settings - Fork 198
Removed default configuration of deprecated rules. #411
Conversation
I had to go back to my original idea of setting all deprecated rules to "false". Otherwise, validate-config is failing because rules are missing from config. In the next major revision, ideally, all of these deprecated rules should be scrubbed from the rule repository completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@JoshuaKGoldberg @caghand Also, check out the final commit. The recommended ruleset is generated by the source file, so you turn rules off in the source code of that rule. |
final commit is here: ed832e7 |
Thank you for the fix! :) |
Is there any news about 5.0.3 release ? I'm waiting for version 5.0.3 ~ 😃 |
me too :-) I notice I have the following being displayed. I presume that this commit fixes that - right ? Warning: no-duplicate-case rule is deprecated. Replace your usage with the TSLint no-duplicate-switch-case rule. |
@vreality64 and @appsolutegeek: Version 5.0.3 has been released. And you are right, this commit (and the associated release) fixes the warnings you are seeing. |
Fixes #410.
I could have set all deprecated rules to "false". But instead, I have dropped them completely. I did not want to interfere with any rule configurations that the user might have customized elsewhere.