Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Removed default configuration of deprecated rules. #411

Closed
wants to merge 2 commits into from
Closed

Removed default configuration of deprecated rules. #411

wants to merge 2 commits into from

Conversation

caghand
Copy link
Member

@caghand caghand commented Jan 22, 2018

Fixes #410.
I could have set all deprecated rules to "false". But instead, I have dropped them completely. I did not want to interfere with any rule configurations that the user might have customized elsewhere.

@msftclas
Copy link

msftclas commented Jan 22, 2018

CLA assistant check
All committers have signed the CLA.

@caghand
Copy link
Member Author

caghand commented Jan 22, 2018

I had to go back to my original idea of setting all deprecated rules to "false". Otherwise, validate-config is failing because rules are missing from config. In the next major revision, ideally, all of these deprecated rules should be scrubbed from the rule repository completely.

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@HamletDRC HamletDRC self-assigned this Jan 31, 2018
@HamletDRC HamletDRC added this to the 5.0.3 milestone Jan 31, 2018
@HamletDRC HamletDRC closed this in ed832e7 Jan 31, 2018
@HamletDRC
Copy link
Member

@JoshuaKGoldberg @caghand
Do you need a release?

Also, check out the final commit. The recommended ruleset is generated by the source file, so you turn rules off in the source code of that rule.

@HamletDRC
Copy link
Member

final commit is here: ed832e7

@caghand
Copy link
Member Author

caghand commented Feb 1, 2018

Thank you for the fix! :)
Well, it would be nice to have a release, because we would be able to get rid of the warnings in our build. It would fix #410 basically.
Are you planning to release 5.0.3 soon?

@vreality64
Copy link

Is there any news about 5.0.3 release ? I'm waiting for version 5.0.3 ~ 😃

@iangregsondev
Copy link

me too :-) I notice I have the following being displayed. I presume that this commit fixes that - right ?

Warning: no-duplicate-case rule is deprecated. Replace your usage with the TSLint no-duplicate-switch-case rule.
Warning: no-stateless-class rule is deprecated. Replace your usage with the TSLint no-unnecessary-class rule.
Warning: no-var-self rule is deprecated. Replace your usage with the TSLint no-this-assignment rule.
Warning: valid-typeof rule is deprecated. Replace your usage with the TSLint typeof-compare rule.

@caghand
Copy link
Member Author

caghand commented Feb 22, 2018

@vreality64 and @appsolutegeek: Version 5.0.3 has been released. And you are right, this commit (and the associated release) fixes the warnings you are seeing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants