Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code font in "Find References" does not work for me #28610

Closed
bpasero opened this issue Jun 13, 2017 · 5 comments
Closed

Code font in "Find References" does not work for me #28610

bpasero opened this issue Jun 13, 2017 · 5 comments
Assignees
Labels
ux User experience issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 13, 2017

I see we now use the editor font in the "Find References" tree:

image

First of all, if we start to use this we should also use it in the search results view to be consistent (the results already look very similar).

I suggest to have a setting for this though, I prefer the workbench font for search results in lists like that.

//cc @Microsoft/vscode for more UX input

@bpasero bpasero added the ux User experience issues label Jun 13, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 13, 2017

Agree for consistency and search.
What is a bit visually jarring to me here is a combination of fonts used in the find all references tree (I understand this is the only logical way to do it)

screen shot 2017-06-13 at 12 02 31

@jrieken jrieken added this to the June 2017 milestone Jun 13, 2017
@jrieken
Copy link
Member

jrieken commented Jun 13, 2017

Yeah, it is a little ugly

@joaomoreno
Copy link
Member

joaomoreno commented Jun 14, 2017

I love it. Code type should be monospace; otherwise it shouldn't.

This is the right way to go.

First of all, if we start to use this we should also use it in the search results view to be consistent (the results already look very similar).

Yep, we should fix every spot where we render code and use a non-monospace font.

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2017

Yep, we should fix every spot where we render code and use a non-monospace font.

Need to be careful though, monospace text is a lot wider and the viewlet is typically very narrow. Doing this may have a usability impact on smaller screens.

@chrisdias
Copy link
Member

To me it looks like a bug when we show code in the editor/monospace font but it is not colorized.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues
Projects
None yet
Development

No branches or pull requests

6 participants