Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt-F-S doesn't save the current file #5556

Closed
Fozzy0007 opened this issue Apr 20, 2016 · 16 comments
Closed

Alt-F-S doesn't save the current file #5556

Fozzy0007 opened this issue Apr 20, 2016 · 16 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@Fozzy0007
Copy link

  • VSCode Version:
  • OS Version:

Steps to Reproduce:

  1. edit a file (VSCode marks it as needing to be saved)
  2. Alt+F+S

file doesn't save. in any other windows program, chording Alt+F (let go of F, keep holding Alt) + S will save the file.

if you let go of "Alt" between F and S, it works. my muscle memory is messing with me.

@Tyriar
Copy link
Member

Tyriar commented Apr 20, 2016

This is an Electron issue atom/atom#10732

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Apr 20, 2016
@bpasero bpasero added this to the Backlog milestone Apr 21, 2016
@Treit
Copy link

Treit commented Nov 23, 2016

The discussion in issue atom/atom#10732 concludes that this is something different and not the same issue as atom/atom#10732.

@Tyriar
Copy link
Member

Tyriar commented Nov 28, 2016

As mentioned in the atom issue, the underlying issue is related to electron, not vscode.

@Treit
Copy link

Treit commented Nov 28, 2016

Is there an active Electron issue tracking this? I couldn't find one. I read through the issues described here (electron/electron#2504) but none of them quite seem to match the behavior this issue is talking about, which is that a three-character combination like Alt+F+S does not do anything and you have to release the Alt key to make it work.

@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2016

That does look like the upstream issue as it tracks a bunch of problems with it.

@bpasero bpasero added workbench accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed bug Issue identified by VS Code Team member as probable bug labels Apr 7, 2017
@SteveALee
Copy link

It's seems to be specific to ALT+F, S as other mnemonics in the file menu like A (Save AS) P (prefs sub menu) work fine

@bpasero bpasero added the menu label May 26, 2017
@myfairsyer
Copy link

myfairsyer commented Jul 24, 2017

other mnemonics in the file menu like A (Save AS) P (prefs sub menu) work fine

Not for me. (Win10, VSC 1.14.1)

@WereDev
Copy link

WereDev commented Jul 28, 2017

I am having a similar issue. In fact, none of the Alt+ key combinations work for opening a menu. For instance, Alt+F should open the file menu, but it does nothing on my machine. I have no idea why this is an issue as it works in my other applications.

Win10, VSC 1.14.2

@JackTrapper
Copy link

JackTrapper commented Nov 14, 2017

As mentioned in the atom issue, the underlying issue is related to electron, not vscode.

It may be because of electron; but vscode is the one that decided to use electron.

If electron is the problem, and it's unsolvable by electron, then its try to move to a different UI framework.

@bpasero bpasero removed this from the Backlog milestone Nov 16, 2017
@jasenf
Copy link

jasenf commented Nov 16, 2017

I swear this was working.

It's always been my preferred way of saving files. But now, in the FIle menu, save Workspace has taken over the "S" spot for a shortcut key. Maybe if we could just change the shortcut keys around?

@WereDev
Copy link

WereDev commented Nov 17, 2017

@JackTrapper @jasenf

This was updated in another ticket, thought it was here too. The problem was Scroll Lock. When it's enabled, the Alt key menu stuff doesn't work right. Everything is fine when it's disabled. Not sure if you're experiencing the same thing or if you've come across something different.

@jasenf
Copy link

jasenf commented Nov 17, 2017

I think my issue is new. The Alt-F then S sequence is now taken by Save Workspace. Pretty sure until a recent release the S was to save a file.

@JackTrapper
Copy link

It's something different.

  • Press Alt
  • Press F
  • Release F
  • Press S
  • Release S (no save)
  • Release Alt

The problem is that people don't read the Steps to Reproduce, and just scroll through; thinking they get the gist.

@bpasero
Copy link
Member

bpasero commented Jul 5, 2018

We should support this with the new custom menu implementation.

@sbatten
Copy link
Member

sbatten commented Jul 5, 2018

related #52935

@bpasero
Copy link
Member

bpasero commented Aug 17, 2018

Duplicate of #52935

@bpasero bpasero marked this as a duplicate of #52935 Aug 17, 2018
@bpasero bpasero closed this as completed Aug 17, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

10 participants