Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Cannot save hidden files #931

Closed
bpasero opened this issue Dec 2, 2015 · 2 comments · Fixed by #31733
Closed

Windows: Cannot save hidden files #931

bpasero opened this issue Dec 2, 2015 · 2 comments · Fixed by #31733
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2017

Comments

@bpasero
Copy link
Member

bpasero commented Dec 2, 2015

node.js returns a EPERM error when trying to save files with hidden attribute.
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 2, 2015
@bpasero bpasero self-assigned this Dec 2, 2015
@bpasero bpasero added this to the Backlog milestone Dec 2, 2015
@bpasero bpasero mentioned this issue Dec 2, 2015
Closed
@rakkarage
Copy link

👍

@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 21, 2016
@bpasero bpasero added file-explorer Explorer widget issues and removed bug Issue identified by VS Code Team member as probable bug labels Apr 7, 2017
This was referenced Jul 30, 2017
Merged
Closed
@bpasero bpasero added the verification-needed Verification of issue is requested label Aug 13, 2017
@bpasero bpasero modified the milestones: August 2017, Backlog Aug 13, 2017
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 13, 2017
@bpasero bpasero mentioned this issue Aug 13, 2017
Closed
bpasero pushed a commit that referenced this issue Aug 15, 2017
@seishun @bpasero
Use r+ with truncation when saving existing files (#31733)
cc9d8fc 
* Use r+ with truncation when saving existing files

'w' doesn't work with hidden files.

Fixes: #931

* use r+ only if EPERM is caught

* add check for Windows

* move writing to a separate method

* nits

* remove string overload for options

* remove encoding property from writeFileAndFlush
@bpasero
Copy link
Member Author

bpasero commented Aug 28, 2017

Verification (Windows): set a file to hidden (from properties) and try to save it via VSCode with changes, should work.

@isidorn isidorn added the verified Verification succeeded label Aug 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

Successfully merging a pull request may close this issue.

Use r+ with truncation when saving existing files
3 participants
@bpasero @rakkarage @isidorn