This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Client: Cache global state assemblies by name #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandyarmstrong
requested review from
abock,
bojanrajkovic and
lewing
as code owners
abock
previously approved these changes
Jul 6, 2018
1. Open Workbooks 2. Create a XF iOS workbook 3. Create a non-XF iOS workbook The second workbook, for whatever reason, doesn't set a PEImage for the global state assembly, so the client tries to resolve it from a different location, leading to an exception. Cache to avoid this. Will be nice when this reflection loading can go away.
abock
approved these changes
Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second workbook, for whatever reason, doesn't set a PEImage for the
global state assembly, so the client tries to resolve it from a different
location, leading to an exception.
Cache to avoid this. Will be nice when this reflection loading can go away.