Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect example TelemetryInitializer #89467

Closed
cijothomas opened this issue Mar 9, 2022 · 3 comments
Closed

Incorrect example TelemetryInitializer #89467

cijothomas opened this issue Mar 9, 2022 · 3 comments

Comments

@cijothomas
Copy link
Contributor

https://docs.microsoft.com/azure/azure-monitor/app/api-filtering-sampling#add-information-from-httpcontext
The example given above is incorrect:

  1. It does not work in ASP.NET
  2. It might work in ASP.NET Core, but its not thread safe and may cause application hangs. (Synchronize access to HttpContext microsoft/ApplicationInsights-dotnet#1313)

Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@MonikaReddy-MSFT
Copy link
Contributor

Thanks for bringing this to our attention. We will investigate it further and update you shortly.

@AaronMaxwell
Copy link
Contributor

Thanks for your dedication to our documentation.

An internal work item has been filed at the following location for scoping and prioritization.

https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1930460

@AaronMaxwell
Copy link
Contributor

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants