Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenComputers/CodeChickenLib network leaks & EnderStorage frequency tracking #496

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

jchung01
Copy link
Contributor

Main goal of this PR is to fix the network leaks, which look like LEAK: ByteBuf.release() was not called before it's garbage-collected; I found the EnderStorage bug while I was diagnosing the CodeChickenLib (CCL) leak.

Fix OpenComputers (OC) not releasing their packets.

Fix CCL not releasing their PacketCustom payloads.

Fix EnderStorage adding duplicate Frequency entries in TankSynchronizer.

  • This was because Frequency broke the Object equality contract by overriding hashCode() but not equals().

Debugging the network pipeline is confusing 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants