Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] AE2: request().isCanceled() is returned false when the request failed #3742

Open
yuton502 opened this issue Oct 18, 2024 · 2 comments

Comments

@yuton502
Copy link

ME Controller connected to the adapter makes a request for autocraft using component.
If there are not enough resources, the request itself will fail, but me_controller.getCraftables().request().isCanceled() will return false.

request().isCanceled() should return true when the request failed.

image
Above, the request failed.
Below, the request succeeded.

  • Minecraft 1.12.2
  • OpenComputers 1.12.2-1.8.6
  • Gregtech Expert 2 v2.7.7 Modpack
@yuton502 yuton502 changed the title [1.12.2] AE2: "request().isCanceled()" is returned "false" when request failed [1.12.2] AE2: "request().isCanceled()" is returned "false" when the request failed Oct 18, 2024
@yuton502 yuton502 changed the title [1.12.2] AE2: "request().isCanceled()" is returned "false" when the request failed [1.12.2] AE2: request().isCanceled() is returned false when the request failed Oct 18, 2024
@yuton502 yuton502 changed the title [1.12.2] AE2: request().isCanceled() is returned false when the request failed [1.12.2] AE2: request().isCanceled() is returned false when the request failed Oct 18, 2024
@Niels1006
Copy link

Note from me, you can get the message with local _, msg = v.craft.isCanceled() and then check whether it is nil or not to get if a craft failed. I just assumed the craft failed if its not nil, idk if there are error messages but it still succeeded

@yuton502
Copy link
Author

Thank you for looking for a solution. I confirmed to work correctly it.
It is just a workaround for the issue, so I'm going to leave this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants