-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target NetStandard to support .NET Core #10
Comments
You mean in nuspec? I have to check out what exactly works. But yes, the idea certainly a good one. |
I think that you have to specify the target frameworks in the project file. The best option is probably to upgrade to the new |
@FlorianHockmann Yes, I know. I'm just trying to understand the Cake's support for .NET Core. |
Support for NetStandard would be really useful. So a big +1 from my site for this issue. |
I'm certainly looking into this. Anybody knows of a Cake addin that supports .NET Standard? |
Cake.Npm seems to support it in addition to .NET Framework 4.5 and 4.6. |
Looking at Cake.Npm. It references just (non-net standard) Cake.Core. I wonder whether it works fine with Cake.CoreCLR. |
@secana @FlorianHockmann Can you guys give it a spin with .NET Standard/Core? You'll find it (for testing) on myget at Version is 0.7.7. |
@MihaMarkic @FlorianHockmann I'll start testing the package this week. As soon as I've some results I'll share my feedback here |
@MihaMarkic Could you provide an download link for the package? Under Linux it's not possible to use |
I've tested DockerBuild under Linux in a Cake script and it works with netstandard and .net core. Pretty cool. I'll test a few more things and report back. |
One small thing: Your DockerPush* classes are in the folder Pull and the DockerPull* classes are in the folder Push I guess that's not the way it was meant to be |
Summary: I've tested the basic docker stuff and everything works fine with .Net Core I would say you can publish the new version to NuGet. Regards, secana |
@secana, thank you very much. I'll check about that folders mismatch. |
@MihaMarkic Could you please upload the 0.7.7 to the NuGet gallery? We could start using it then in our build scripts which would be a great help. |
Uploaded 0.7.7 to NuGet.org. Thanks @FlorianHockmann and @secana for testing, suggestion and help. |
Could you add NetStandard as a target framework so that Cake.Docker can be used with .NET Core? Note also that there seem to be plans to deprecate Mono in Cake.
The text was updated successfully, but these errors were encountered: