-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive IsList
instances for EnumSet
and EnumMap
#24
Conversation
Achievement unlocked: fail all CI jobs! On a more serious note, it fails with
so it's unlikely to be related to my changes. |
Huh, I see a very old haskell-ci (https://github.com/Mikolaj/enummapset/blob/master/.github/workflows/haskell-ci.yml#L11C12-L11C25), so no wonder it fails. Somebody needs to regenerate the script using a new haskell-ci version. |
I've regenerated the CI. Could you try rebasing on master? |
c5cf229
to
aca3735
Compare
aca3735
to
9f7577d
Compare
@Mikolaj done! Thanks for taking a look into this — the CI actually caught some issues with the earlier GHC versions that I've fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Shall we merge?
Yep, all clear on my side to merge! While we're at it, could you please make and upload a new version of the package too, so I could depend on it in my code? Thanks! |
Shall that be 0.7.3.0 or 0.8.1.0? Does your change break PvP? |
I guess this a benign/almost external extension of the API, so let's stick with a minor bump: https://hackage.haskell.org/package/enummapset-0.7.3.0 |
@0xd34df00d: thank you for the valuable contribution! |
Thank you for merging and releasing! This could break some existing code if it defines its own |
This is an IMO handy usability enhancement, and it also makes
EnumSet
/EnumMap
more of a drop-in replacement forIntSet
/IntMap
/HashSet
/HashMap
, all of which have anIsList
instance.