Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive IsList instances for EnumSet and EnumMap #24

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

0xd34df00d
Copy link
Contributor

This is an IMO handy usability enhancement, and it also makes EnumSet/EnumMap more of a drop-in replacement for IntSet/IntMap/HashSet/HashMap, all of which have an IsList instance.

@0xd34df00d
Copy link
Contributor Author

Achievement unlocked: fail all CI jobs!

On a more serious note, it fails with

/usr/bin/docker exec  b2eb26cb4f33171f79399806f746b34cab8db705398a8ffa873ef92b5b68f9a7 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

so it's unlikely to be related to my changes.

@Mikolaj
Copy link
Owner

Mikolaj commented Aug 22, 2024

Huh, I see a very old haskell-ci (https://github.com/Mikolaj/enummapset/blob/master/.github/workflows/haskell-ci.yml#L11C12-L11C25), so no wonder it fails. Somebody needs to regenerate the script using a new haskell-ci version.

@Mikolaj
Copy link
Owner

Mikolaj commented Sep 2, 2024

I've regenerated the CI. Could you try rebasing on master?

@0xd34df00d
Copy link
Contributor Author

@Mikolaj done! Thanks for taking a look into this — the CI actually caught some issues with the earlier GHC versions that I've fixed.

Copy link
Owner

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we merge?

@0xd34df00d
Copy link
Contributor Author

Yep, all clear on my side to merge!

While we're at it, could you please make and upload a new version of the package too, so I could depend on it in my code? Thanks!

@Mikolaj Mikolaj merged commit 5b112bf into Mikolaj:master Sep 4, 2024
9 checks passed
@Mikolaj
Copy link
Owner

Mikolaj commented Sep 4, 2024

Shall that be 0.7.3.0 or 0.8.1.0? Does your change break PvP?

@Mikolaj
Copy link
Owner

Mikolaj commented Sep 4, 2024

I guess this a benign/almost external extension of the API, so let's stick with a minor bump: https://hackage.haskell.org/package/enummapset-0.7.3.0

@Mikolaj
Copy link
Owner

Mikolaj commented Sep 4, 2024

@0xd34df00d: thank you for the valuable contribution!

@0xd34df00d
Copy link
Contributor Author

Thank you for merging and releasing!

This could break some existing code if it defines its own IsList instance for EnumMap or EnumSet, but that'll be an orphan instance, and those are generally "you know what you're signing up for" kind of thing IMO. So, a minor bump is good.

@0xd34df00d 0xd34df00d deleted the add-islist branch September 5, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants