Remove indirection table zkapp_fee_payer #10917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
the
ci-build-me
lk86
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OCaml,
Fee_payer.trefers toBody.Fee_payer.tand a signature. In the archive db, we don't store the signature, so the tablezkapp_fee_payerreferred to entries inzkapp_fee_payer_body, and contained no other information. Therefore, that table can be removed.This change required small changes to
extract_blocksand thereplayer, and editing the SQL for the replayer test, which succeeded locally. Also tested thatextract_blocksworks on the data in the replayer test.Closes #10916.