Consolidated preconditions within Party #11096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`account_precondition` and `protocol_state_precondition` are now colocated under a `preconditions` umbrella called: `account` and `network` respectively ala the comments in o1-labs/o1js#179 At the moment, the `protocol_state_precondition` vestige is left in the code in many places. Assuming this PR is accepted, I'll open a cleanup issue to go through and rename those variables and modules throughout the codebase. As these names won't ever see the light of day from a user's perspective (neither via GraphQL nor JSON nor SnarkyJS etc) it's benign to leave those in for now.
bkase
added
the
ci-build-me
mrmr1993
reviewed
May 25, 2022
| @@ -795,7 +795,7 @@ module Body = struct | |||
| ; sequence_events : Events'.Stable.V1.t | |||
| ; protocol_state_precondition : | |||
There was a problem hiding this comment.
change this to network_precondition to be consistent?
There was a problem hiding this comment.
I did this via the @name annotation for now because I didn't want this PR to balloon in scope. Was planning on making an issue for addressing that later. Is that okay?
mitschabaude
approved these changes
May 26, 2022
There was a problem hiding this comment.
snarkyjs / graphql side gets my 👍🏻
It really speaks for our architecture how easy this change across projects was @bkase
…ns-parties' into feature/consolidated-preconditions-parties
…ed-preconditions-parties
…dated-preconditions-parties
Failing unit test on transaction_pool passes now
…ed-preconditions-parties
…dated-preconditions-parties
…ed-preconditions-parties
…ed-preconditions-parties
mrmr1993
approved these changes
May 31, 2022
mitschabaude
added a commit
to o1-labs/o1js
that referenced
this pull request
Jun 3, 2022
Consolidate preconditions MinaProtocol/mina#11096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
account_preconditionandprotocol_state_preconditionare nowcolocated under a
preconditionsumbrella called:accountandnetworkrespectively ala the comments in o1-labs/o1js#179At the moment, the
protocol_state_preconditionvestige is left in thecode in many places. Assuming this PR is accepted, I'll open a cleanup
issue to go through and rename those variables and modules throughout
the codebase. As these names won't ever see the light of day from a
user's perspective (neither via GraphQL nor JSON nor SnarkyJS etc) it's
benign to leave those in for now.
If existing tests pass, I did this surgery properly