Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of URLs #14809

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Fix parsing of URLs #14809

merged 3 commits into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. Fix parsing of URLs 

    With this change, we now support all of the likely URLs, including
```
https://foo:bar@github.com/ORG/REPO.git
https://github.com/ORG/REPO.git
git://github.com/ORG/REPO.git
git@github.com:ORG/REPO.git
```
    @mrmr1993
    mrmr1993 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    24c39c2 View commit details
    Browse the repository at this point in the history

  2. If our regex will fail, exit early

    @mrmr1993
    mrmr1993 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b071672 View commit details
    Browse the repository at this point in the history

  3. Add a message on failure

    @mrmr1993
    mrmr1993 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f2ddea6 View commit details
    Browse the repository at this point in the history