Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Totally Disable zkApp Commands in case of Emergency #14880

Merged
merged 6 commits into from
Jan 16, 2024
Merged

RFC: Totally Disable zkApp Commands in case of Emergency #14880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0a50c4
Create initial draft of rfc
ejMina226 Jan 16, 2024
678a7b5
Merge branch 'develop' into disable-zkap-commands
ejMina226 Jan 16, 2024
cb33ae9
Add in detailed design
ejMina226 Jan 16, 2024
8ce2f84
Merge branch 'develop' into disable-zkap-commands
ejMina226 Jan 16, 2024
c901d87
Add link
ejMina226 Jan 16, 2024
531861a
Typo
ejMina226 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 rfcs/0057-disable-zkapp-commands.md → rfcs/0057-hardcap-zkapp-commands.md
View file
Open in desktop
File renamed without changes.
8 changes: 8 additions & 0 deletions rfcs/0058-disable-zkapp-commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
## Summary
*Soft* and *hard* limits for zkApp commands have already been implemented (see `rfcs/0054-limit-zkapp-cmds-per-block.md` and `0057-hardcap-zkapp-commands.md`). However, both of these changes still permit the inclusion of zkApp commands into the Mina node's mempool, and their dissemination via gossiping. If we wish to truly disable zkApp commands in the network then a more exhaustive exclusion is required.

## Detailed design
The change should sit behind a compile-time flag (similar to the ITN `itn_features`). Changing [this code](https://github.com/MinaProtocol/mina/blob/03c403e2c1e57a36de4e5b92f75856c825cb7e7e/src/lib/mina_base/user_command.ml#L405) so that all zkApp commands are treated as malformed will prevent them from being added to the mempool.

## Testing
The change can be tested by switching on the flag and firing zkApp commands at a node. The node should not accept any of the zkApp commands, nor should any be gossiped to other nodes in the network, which can be checked by querying the GraphQL endpoints.