From 000a7ff52045b6f8034841921822aa21fe6789a0 Mon Sep 17 00:00:00 2001 From: mrsean2k Date: Fri, 14 Mar 2014 15:25:18 +0000 Subject: [PATCH] Address RegEx Performance RegEx performance of match can cause issues on some browsers for some images; replace with substring. --- public/javascripts/imageupload.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/public/javascripts/imageupload.js b/public/javascripts/imageupload.js index c3c1453..b81bf2f 100644 --- a/public/javascripts/imageupload.js +++ b/public/javascripts/imageupload.js @@ -87,9 +87,10 @@ angular.module('imageupload', []) var doResizing = function(imageResult, callback) { createImage(imageResult.url, function(image) { var dataURL = resizeImage(image, scope); + var imageType = dataURL.substring(5, dataURL.indexOf(';')); imageResult.resized = { dataURL: dataURL, - type: dataURL.match(/:(.+\/.+);/)[1], + type: imageType }; callback(imageResult); });