Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix midi device in orphaned serials dialog #1797

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

Koseng
Copy link
Contributor

@Koseng Koseng commented Jun 28, 2024

fixes #1795
It was not intended to now have the orphaned serials dialog include midi devices. Something was half prepared and not fully tested. Also orphaned serials are currently not necessary on midi devices.

Current bug only shows up when midi devices and mobi modules are connected at the same time.

-> Completely remove midi from orphaned serials.

@Koseng Koseng requested a review from DocMoebiuz as a code owner June 28, 2024 18:53
Copy link

github-actions bot commented Jul 9, 2024

Build for this pull request:
MobiFlightConnector.zip

@Koseng
Copy link
Contributor Author

Koseng commented Jul 21, 2024

Successfully tested by discord user "vinKaiZen§´"

@DocMoebiuz DocMoebiuz merged commit 31378b5 into MobiFlight:main Jul 23, 2024
1 check passed
@DocMoebiuz DocMoebiuz added the bug Something isn't working in a officially released version label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in a officially released version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MF10.3.0 - Midi device now wants Orphaned serial (no selecteable choice) -> cancel -> working (bug?)
2 participants