-
Notifications
You must be signed in to change notification settings - Fork 247
Preliminary version of hardware Serial communication module for esp32 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
diogoviannaaraujo
wants to merge
981
commits into
Moddable-OpenSource:public
from
diogoviannaaraujo:serial-module
Closed
Preliminary version of hardware Serial communication module for esp32 #73
diogoviannaaraujo
wants to merge
981
commits into
Moddable-OpenSource:public
from
diogoviannaaraujo:serial-module
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because configuration may change based on application defines
remove some warnings
remove some warnings
Contributor
Author
|
Hi is hardware uart a desired function for the project? |
Collaborator
|
Diogo, I had sent this to your email, but perhaps it didn't arrive: We will need a signed Contributor license before we can accept the It can be found at: |
mkellner
pushed a commit
that referenced
this pull request
Aug 28, 2018
mkellner
pushed a commit
that referenced
this pull request
Sep 22, 2018
mkellner
pushed a commit
that referenced
this pull request
Oct 1, 2018
mkellner
pushed a commit
that referenced
this pull request
Oct 11, 2018
mkellner
pushed a commit
that referenced
this pull request
Oct 22, 2018
mkellner
pushed a commit
that referenced
this pull request
Oct 30, 2018
mkellner
pushed a commit
that referenced
this pull request
Nov 13, 2018
mkellner
pushed a commit
that referenced
this pull request
Nov 22, 2018
mkellner
pushed a commit
that referenced
this pull request
Dec 20, 2018
mkellner
pushed a commit
that referenced
this pull request
Dec 21, 2018
mkellner
pushed a commit
that referenced
this pull request
Jan 7, 2019
mkellner
pushed a commit
that referenced
this pull request
Jan 29, 2019
mkellner
pushed a commit
that referenced
this pull request
Feb 14, 2019
mkellner
pushed a commit
that referenced
this pull request
Feb 21, 2019
mkellner
pushed a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After 2 days reading the documentation, other modules and lots of compile error I think I did get a funcional Serial module for the Esp32. Ive based on the i2c module and the esp idf examples.
This is preliminary work and I have no prior C experience, so this probably is nowhere near stable.
I was able to get a loopback response and do some initial talk with a SIMCom SIM800L GSM module. I do get some trash chars sometimes when talking with the GSM module, but don't know if its the module or something in the code.
Im posting this seeking for review on my code and some guidance.
My main difficulties are about the buffer, max message sizes and converting those buffer arrays into strings.
Since im usually programming on high level high memory environments any feedback in how to correct handle the data for this module is really appreciated.
Thanks in advance,
Diogo