Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProfilePinnedRepositories): adds a card with pinned repositories from the user #21

Merged

Conversation

christianfds
Copy link
Contributor

Closes #14

@vercel
Copy link

vercel bot commented Oct 6, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @Mridul2820 on Vercel.

@Mridul2820 first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
git-to-get ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 2:27AM (UTC)

@Mridul2820
Copy link
Owner

Mridul2820 commented Oct 11, 2022

Hi @christianfds You have done great work.
Just a few changes needed

  • Can you make the fork star icons the same on GitHub
  • Can you add a repo symbol in front of the repo name
  • And add a language color circle like GitHub at the bottom of every card

@Mridul2820 Mridul2820 added hacktoberfest-accepted Hacktoberfest Accepted hacktoberfest Hacktoberfest labels Oct 11, 2022
@christianfds christianfds force-pushed the feature-add-pinned-repositories branch from d0b55f9 to b674900 Compare October 12, 2022 22:52
@christianfds
Copy link
Contributor Author

christianfds commented Oct 12, 2022

@Mridul2820 just did all the requested changes and also merged with main and added the dark theme to the component.

I'm just having an small bug with this div:

image

For some reason it only loads the classes if i add/remove something and the element hot reloads on screen, but when i hit F5 there are no classes again '-'

image

Do you have any ideia why this might be happening?

NVM, its working now

@Mridul2820
Copy link
Owner

There is a wired bug for pinned repo cards. The overflow scroll is gone
Screenshot from 2022-10-13 09-33-54
Can you please look at that?

@christianfds
Copy link
Contributor Author

Yeah, that's exactly what has happening when i was testing. After i cleaned every tmp, cache, cookie i could think and it worked I thought it was something in here. I will take another look at it, maybe rewrite somethings.

@Mridul2820 Mridul2820 merged commit fca639b into Mridul2820:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Pinned Repository of the User
2 participants