fix dark mode bugs with border-width and ProfileCalendar #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @Mridul2820 on Vercel. @Mridul2820 first needs to authorize it. |
xnatsuk
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @xnatsuk, borders are required. Without the borders, the cards are separate from each other. |
|
Seemed okay to me. I'll add them again |
Removed dark only borders, making elements change size on theme change.
|
@Mridul2820 borders should be the same size across both themes now. |
|
Hi @xnatsuk, a few things if you enhance for the dark mode, it will look great
|
|
@Mridul2820 I didn't fix the axis label color because I'm not familiar with it's dependency, but the other colors are more visible now. |
Mridul2820
added
hacktoberfest-accepted
Mridul2820
approved these changes
Oct 19, 2022
|
Thank you for contributing! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24