From 188c125abfb5cb3fd17fa1a1367bd6e0fc921105 Mon Sep 17 00:00:00 2001 From: Shubham Yadav Date: Thu, 25 Apr 2019 22:33:07 +0530 Subject: [PATCH] Fix for CodeHint Description CSS Issue (#14728) * Fix for overlapping dropdown div * Cleanup #1 --- src/editor/CodeHintList.js | 6 +----- src/styles/brackets_patterns_override.less | 3 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/editor/CodeHintList.js b/src/editor/CodeHintList.js index 5a132281d75..23380301d2d 100644 --- a/src/editor/CodeHintList.js +++ b/src/editor/CodeHintList.js @@ -266,16 +266,12 @@ define(function (require, exports, module) { // attach to DOM $parent.append($ul); - $parent.find(".hint-list-offset").remove(); - $("
").appendTo($parent); - // If a a description field requested attach one if (this.enableDescription) { // Remove the desc element first to ensure DOM order $parent.find("#codehint-desc").remove(); $parent.append(""); $ul.addClass("withDesc"); - $parent.find(".hint-list-offset").addClass("withDesc"); } this._setSelectedIndex(selectInitial ? 0 : -1); } @@ -323,7 +319,7 @@ define(function (require, exports, module) { if (descOffset === 0) { descOffset = menuHeight - descOverhang; } - this.$hintMenu.find(".hint-list-offset").css("height", descOffset - 1); + this.$hintMenu.find("#codehint-desc").css("margin-top", descOffset - 1); return {left: posLeft, top: posTop, width: availableWidth}; }; diff --git a/src/styles/brackets_patterns_override.less b/src/styles/brackets_patterns_override.less index e1de2ba3902..6ce6c1aee15 100644 --- a/src/styles/brackets_patterns_override.less +++ b/src/styles/brackets_patterns_override.less @@ -586,11 +586,10 @@ a:focus { #codehint-desc { background: @bc-codehint-desc; - position: relative; + position: absolute; width: 100%; box-sizing: border-box; float: left; - top: 34px; border-radius: 1px !important; border-top-left-radius: 0px !important; border-top-right-radius: 0px !important;