Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cytoscape JS version to support Z-index #295

Closed
jlaw9 opened this issue Jul 31, 2017 · 4 comments
Closed

Update Cytoscape JS version to support Z-index #295

jlaw9 opened this issue Jul 31, 2017 · 4 comments
Labels

Comments

@jlaw9
Copy link
Collaborator

jlaw9 commented Jul 31, 2017

When I upload a CYJS and an accompanying style JSON file, the "z-compound-depth" and "z-index-compare" attributes do not seem to be stored or used for drawing the graph. When I download the style JSON file (after uploading), the "z-compound-depth" and "z-index-compare" attributes I had set are gone.

I'm trying to set the parent nodes to draw on top of edges so the text can be seen.
28386139-9fe22e34-6c98-11e7-801f-74b5440cc016

I was able to accomplish it using "z-compound-depth" for the parent node TARGETS in my own javascript file (not in GraphSpace).
28386166-b548da16-6c98-11e7-8fd2-33723cf60e4c

@adbharadwaj
Copy link
Collaborator

adbharadwaj commented Jul 31, 2017 via email

@adbharadwaj
Copy link
Collaborator

adbharadwaj commented Aug 4, 2017

This issue is happening because we are using cytoscape.js version 2.7 whereas properties like z-compound-depth are supported by version 3.3 onwards. I tried updating our version to the latest version. But it leads to incompatibility issues with a lot other cytoscape.js extension. Additionally, latest versions do not support event attribute called cyTarget which has led to issues with our popup functionality.

Currently, we cannot update cytoscape.js library.

@adbharadwaj
Copy link
Collaborator

This issue requires some investigation into what changes are required to make this update.

@jlaw9 jlaw9 changed the title Z-index not supported Update Cytoscape JS version Aug 22, 2017
@jlaw9
Copy link
Collaborator Author

jlaw9 commented Oct 22, 2018

I made an issue on Cytoscape js to see if the z-index could be set separately for the node and the node label, but unfortunately it won't be implemented (cytoscape/cytoscape.js#1900).

@jlaw9 jlaw9 changed the title Update Cytoscape JS version Update Cytoscape JS versionto support Z-index Oct 22, 2018
@jlaw9 jlaw9 changed the title Update Cytoscape JS versionto support Z-index Update Cytoscape JS version to support Z-index Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants