Devop/get tokens #41
Closed
Devop/get tokens #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #41 +/- ##
==========================================
- Coverage 4% 3.83% -0.17%
==========================================
Files 377 410 +33
Lines 1625 1695 +70
Branches 107 102 -5
==========================================
Hits 65 65
- Misses 1551 1621 +70
Partials 9 9
Continue to review full report at Codecov.
|
gamalielhere
force-pushed
the
devop/get-tokens
branch
from
d5bd40a to
c3f2240
Compare
kvhnuke
previously requested changes
Aug 8, 2018
src/configs/networks/types/GO.js
Outdated
| @@ -0,0 +1,12 @@ | |||
| const tokens = require('../../../../tokens/tokens-go.json') | |||
src/App.vue
Outdated
| const state = { | ||
| web3: window.web3 ? window.web3.setProvider(this.$store.state.Networks['ETH'][0].url) : web3, | ||
| web3: store.get('network') ? new Web3(new Web3.providers.HttpProvider(store.get('network').url)) : new Web3(new Web3.providers.HttpProvider(this.$store.state.Networks['ETH'][0].url)), |
There was a problem hiding this comment.
it is not always httpProvider, sometimes it can be websocket as well. You can simply pass the url to the web3 and it will recognize
new Web3(store.get('network').url)
https://web3js.readthedocs.io/en/1.0/getting-started.html
| to: web3.utils.toChecksumAddress(address), | ||
| data: data | ||
| }).then(res => unit.fromWei(web3.utils.toBN(res).toString(), 'ether')).catch(err => console.log(err)) | ||
| }).then(res => { | ||
| const tokenBalance = unit.fromWei(web3.utils.toBN(res).toString(), 'ether') |
There was a problem hiding this comment.
const tokenBalance = web3.utils.toBN(res).div(10^token.decimals)
gamalielhere
force-pushed
the
devop/get-tokens
branch
from
4aad87d to
69b569c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devop