Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

small clean up #883

Closed
wants to merge 1 commit into from
Closed

small clean up #883

wants to merge 1 commit into from

Conversation

Zwilla
Copy link
Contributor

@Zwilla Zwilla commented Aug 14, 2017

Note on clean up automatic on line 29 return will be deleted.
Now the code is minifying safe ! Missing some {} and ;

Note on clean up automatic on line 29 return will be deleted.
Now the code is minifying safe ! Missing some {} and ;
@dternyak
Copy link
Contributor

Hey @Zwilla :)

Thanks for all of your PRs.

I have some security concerns around the large diffs here.

Is it possible for you to submit small diffs with only the exact improvement you've made?

Also, do you mind explaining what it is exactly you are fixing a bit more clearly?

Thanks.

@Zwilla
Copy link
Contributor Author

Zwilla commented Aug 15, 2017

ohh, it looks only on GitHub so crazy. With a normal text editor it looks very simple what I have changed.
I added only some missing brackets on line 25 and line 27 / 28 and 30
on line 24 will later add a secure new Buffer.from function, after you merge this one.

Compare it by your self with BB-Edit or NotePad and you will see all is fine.

@dternyak
Copy link
Contributor

@Zwilla

It isn't GitHub -- that patch that you have submitted contains large amounts of changes (even if they are all very minor).

Perhaps you can start checking how large the changes you are making is before submitting?

Thanks.

@Zwilla
Copy link
Contributor Author

Zwilla commented Aug 15, 2017

Here it comes!
b4a6eaf?w=1

Hope we all learned about this trick: camsong/chrome-github-mate#5
EDIT:
〜〜Here I have imported the files!
http://www.mergely.com/JOzKO6be/

Click there on OPTIONS -> ignore white space :)〜〜

@tayvano tayvano closed this Aug 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants