diff --git a/CHANGELOG.md b/CHANGELOG.md index a53d2ca5..bc1ec091 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,7 +34,7 @@ Please also have a look at our - Use more native type declarations and strict mode (#641, #772, #774, #778, #804, #841, #873, #875, #891, #922, #923, #933, #958, #964, #967, #1000, #1044, #1134, #1136, #1137, #1139, #1140, #1141, #1145, - #1162, #1163, #1166, #1172, #1174, #1178) + #1162, #1163, #1166, #1172, #1174, #1178, #1179) - Add visibility to all class/interface constants (#469) ### Deprecated diff --git a/config/phpstan-baseline.neon b/config/phpstan-baseline.neon index a8bd7388..89348ca3 100644 --- a/config/phpstan-baseline.neon +++ b/config/phpstan-baseline.neon @@ -114,12 +114,6 @@ parameters: count: 1 path: ../src/RuleSet/RuleSet.php - - - message: '#^Parameters should have "string" types as the only types passed to this method$#' - identifier: typePerfect.narrowPublicClassMethodParamType - count: 1 - path: ../src/Value/CSSString.php - - message: '#^Loose comparison via "\!\=" is not allowed\.$#' identifier: notEqual.notAllowed diff --git a/src/Value/CSSString.php b/src/Value/CSSString.php index 8b3064bd..7f352502 100644 --- a/src/Value/CSSString.php +++ b/src/Value/CSSString.php @@ -23,10 +23,9 @@ class CSSString extends PrimitiveValue private $string; /** - * @param string $string * @param int<0, max> $lineNumber */ - public function __construct($string, int $lineNumber = 0) + public function __construct(string $string, int $lineNumber = 0) { $this->string = $string; parent::__construct($lineNumber); @@ -74,18 +73,12 @@ public static function parse(ParserState $parserState): CSSString return new CSSString($result, $parserState->currentLine()); } - /** - * @param string $string - */ - public function setString($string): void + public function setString(string $string): void { $this->string = $string; } - /** - * @return string - */ - public function getString() + public function getString(): string { return $this->string; }