Skip to content

[BUGFIX] Correct DocBlock for ParserState::consumeUntil() #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

[BUGFIX] Correct DocBlock for ParserState::consumeUntil() #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be51222
[BUGFIX] Correct DocBlock for `ParserState::consumeUntil()`
JakeQZ Jul 17, 2025
d4942fc
Use `EOF` constant in DocBlock rather than `null`
JakeQZ Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions config/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ parameters:
count: 1
path: ../src/CSSList/Document.php

-
message: '#^Call to function in_array\(\) with arguments null, list\<string\> and true will always evaluate to false\.$#'
identifier: function.impossibleType
count: 1
path: ../src/Parsing/ParserState.php

-
message: '#^Negated boolean expression is always true\.$#'
identifier: booleanNot.alwaysTrue
Expand Down
2 changes: 1 addition & 1 deletion src/Parsing/ParserState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ public function isEnd(): bool
}

/**
* @param list<string>|string $stopCharacters
* @param list<string|self::EOF>|string|self::EOF $stopCharacters
* @param array<int, Comment> $comments
*
* @throws UnexpectedEOFException
Expand Down