Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Symfony 4.4 #1242

Closed
oliverklee opened this issue Nov 30, 2023 · 3 comments · Fixed by #1358
Closed

Drop support for Symfony 4.4 #1242

oliverklee opened this issue Nov 30, 2023 · 3 comments · Fixed by #1358
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@oliverklee
Copy link
Contributor

https://symfony.com/releases

@oliverklee oliverklee added the dependencies Pull requests that update a dependency file label Nov 30, 2023
@oliverklee oliverklee added this to the 8.0.0 milestone Nov 30, 2023
@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 5, 2023

I don't think we should do this until we need to, e.g. because we need a new feature or bugfix.

I made a similar argument against dropping support for 'unsupported' PHP versions until we have to. This was discussed in #1206. In #1207 you tried to re-established support for PHP 7.2, but we found we did actually need to ditch it after all.

Main point is that it's not for us to force users to upgrade third party components if there are no known compatibility issues with the older versions. We've thoroughly tested against these older versions, through each iteration or both our software and theirs, which is more than can be said for the latest version of a third-party component.

'Unsupported' does not mean 'broken'. It just means that the developers have chosen to save resources by not merging any more bug fixes to a previous release branch - which is understandable: as the code deviates, such merges become more and more time-consuming and error-prone.

I've had situations where Composer cannot satisfy dependencies due to chains of minimum and maximum version dependencies leading to one component needing a later version of a dependency than the latest allowed by some other component. I'd rather avoid inflicting that problem on our users unnecessarily.

On that basis, I'm moving this to a future milestone.

@JakeQZ JakeQZ modified the milestones: 8.0.0, Backlog Dec 5, 2023
@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 5, 2023

Also worth noting that some developers do apply security vulnerability fixes to unsupported versions. E.g. WordPress released 4.1.39 on 12 October 2023, almost 9 years after the initial 4.1 release. They don't use semver, so the latest 6.4 is 23 major releases ahead. The latest PHP version supported by WordPress 4.1.39 is PHP 5.6.

@oliverklee oliverklee changed the title Drop support for unsupported Symfony versions Drop support for Symfony 4.4 Oct 28, 2024
@oliverklee
Copy link
Contributor Author

From #1278 (comment):

I propose we skip the unit tests on CI for PHP 8.4 with the lowest dependencies (so we can release version 7.3.0) and drop support for Symfony 4.4 in version 8.0.0.

@oliverklee oliverklee modified the milestones: Backlog, 8.0.0 Oct 28, 2024
@oliverklee oliverklee self-assigned this Oct 30, 2024
oliverklee added a commit that referenced this issue Oct 30, 2024
We'll raise the minimum required bugfix versions for Symfony in a
separate change to ensure PHP 8.4 compatibility even with the lowest
dependencies.

Fixes #1242
@JakeQZ JakeQZ closed this as completed in 0de9c22 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants