Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CURRENT_MATERIAL constant from shaders #175

Open
RohacekD opened this issue Apr 17, 2022 · 1 comment
Open

remove CURRENT_MATERIAL constant from shaders #175

RohacekD opened this issue Apr 17, 2022 · 1 comment
Assignees
@RohacekD
Labels
Refactor

Comments

@RohacekD
Copy link
Collaborator

Describe the bug
This leads to magic constants in shaders and makes it harder to combine shaders together.

Expected behavior
Pass current material through the functions as reference instead of filling magic constant.
@RohacekD RohacekD self-assigned this Apr 17, 2022
@RohacekD
Copy link
Collaborator Author

Fix terrain fragment shader as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RohacekD RohacekD

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RohacekD