Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping while paused #29

Open
wants to merge 1 commit into
base: 19.08
Choose a base branch
from
Open

Allow skipping while paused #29

wants to merge 1 commit into from

Conversation

pixelherodev
Copy link

There's really no reason it should have to be playing to skip, especially because the state is set to autopause when you say the wake word! As is, saying "skip song" is nearly useless because it's never in the playing state, and either way you shouldn't have to do two separate commands (WAKE WORD, resume; WAKE WORD, next song).

@krisgesling
Copy link

Hey there, I just saw this PR when following up on your CLA. Sorry it didn't get looked it last year!

Still seems to be relevant and not sure why it would need to be in a playing state.

Unfortunately as Pandora is US only it's a pain to test these so I'll post in the community. If anyone else can validate this works as expected I'm happy to merge it in.

@krisgesling krisgesling added enhancement New feature or request help wanted Extra attention is needed labels Sep 15, 2020
@pixelherodev
Copy link
Author

I can't even test this anymore, as I haven't been able to get Mycroft working locally again.

mikejgray added a commit to mikejgray/skill-pandora-mycroft that referenced this pull request Jun 8, 2022
@pixelherodev
Copy link
Author

Given that someone else has apparently merged this on their branch, is that good enough to indicate that this is tested? :P If not, I'm just going to close this. I don't use Mycroft anymore, and I'm not going to build it to test a change I no longer care about, sorry :/

@mikejgray
Copy link

Given that someone else has apparently merged this on their branch, is that good enough to indicate that this is tested? :P If not, I'm just going to close this. I don't use Mycroft anymore, and I'm not going to build it to test a change I no longer care about, sorry :/

Just saw this - yes, I merged and tested it, and it seemed to work. I've been off Picroft for a while now and using OVOS/Neon.AI, which are maintained forks of Mycroft. I'm looking at it again as it's now possible to disable a feature that made these classic Mycroft media skills useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants