[SIP-45] Metrics and protocol config changes #20738
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
shio-coder
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
Hi @mwtian , I have updated the PR. |
shio-coder
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
| @@ -3076,6 +3083,13 @@ impl ProtocolConfig { | |||
|
|
|||
| cfg.validator_validate_metadata_cost_base = Some(20000); | |||
| } | |||
| 71 => { | |||
| if chain != Chain::Mainnet { | |||
There was a problem hiding this comment.
Was there a discussion to roll out the max gas price to testnet and mainnet separately, instead of in the same release? cc @dariorussi @sblackshear
There was a problem hiding this comment.
This is just being conservative. If rolling out to mainnet at the same time is acceptable then let's do it!
There was a problem hiding this comment.
Ok. After looking at the related logic a bit, it seems there are some interactions between gas price and max_tx_gas limit, among other effects of using high gas price. I think being a bit conservative is warranted here. We should definitely try out using very high gas price on testnet first before changing the limit on mainnet. We may need to update max_tx_gas or switch to a different parameter limiting gas unit instead of total gas. They can be done separately.
There was a problem hiding this comment.
Yes I have justed realized there is max_tx_gas as well.
Tried to change it locally and that has just caused so many tests to fail (these tests use max_tx_gas as gas budget if not explicitly set). Looks like we are going to need another PR for it.
There was a problem hiding this comment.
Agree let's not change max_tx_gas in this PR. In fact we can postpone changing max_gas_price too if you think just changing it will not be useful. I have asked experts on the gas logic for the best way forward. cc @dariorussi @tzakian
mwtian
deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Active
Description
This is the change that is proposed from SIP-45.
The change includes:
amplification_factor.Kto protocol config.Kis set to 5 starting from Protocol Version 70.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.