Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile Icebin with latest PISM #2

Open
mankoff opened this issue Jun 12, 2023 · 1 comment · May be fixed by #1
Open

Compile Icebin with latest PISM #2

mankoff opened this issue Jun 12, 2023 · 1 comment · May be fixed by #1

Comments

@mankoff
Copy link
Member

mankoff commented Jun 12, 2023

By the way, void IBIceModel::massContExplicitStep() was designed to override an IceModel method (in PISM) that no longer exists. I refactored the mass transport code and (sadly) had to break this in the process. :-( Let's talk about this later!

_Originally posted by @ckhroulev in https://github.com/NASA-GISS/landice/issues/31#issuecomment-1585248842_u
@mankoff mankoff linked a pull request Jun 12, 2023 that will close this issue
Open
@mankoff mankoff linked a pull request Jun 12, 2023 that will close this issue
WIP: Icebin changes needed for latest PISM #1
Open
@mankoff
Copy link
Member Author

mankoff commented Jun 12, 2023

Lots of Icebin compile errors. A small sample:

/home/kdm/projects/GISS/meli_pismupgrade/src/icebin/slib/icebin/pism/IceCoupler_PISM.cpp: In constructor ‘icebin::gpism::IceCoupler_PISM::IceCoupler_PISM(const icebin::IceCoupler::Params&)’:
/home/kdm/projects/GISS/meli_pismupgrade/src/icebin/slib/icebin/pism/IceCoupler_PISM.cpp:52:27: error: no matching function for call to ‘pism::IceModelVec2S::IceModelVec2S()’
   52 |     write_pism_inputs(true)
      |                           ^
In file included from /home/kdm/projects/GISS/meli_pismupgrade/opt/include/pism/util/Diagnostic.hh:29,
                 from /home/kdm/projects/GISS/meli_pismupgrade/opt/include/pism/util/Component.hh:31,
                 from /home/kdm/projects/GISS/meli_pismupgrade/opt/include/pism/stressbalance/StressBalance.hh:24,
                 from /home/kdm/projects/GISS/meli_pismupgrade/src/icebin/slib/icebin/pism/IceCoupler_PISM.cpp:29:
/home/kdm/projects/GISS/meli_pismupgrade/opt/include/pism/util/iceModelVec.hh:338:3: note: candidate: ‘pism::IceModelVec2S::IceModelVec2S(pism::IceGrid::ConstPtr, const string&, pism::IceModelVecKind, int)’
  338 |   IceModelVec2S(IceGrid::ConstPtr grid, const std::string &name,
      |   ^~~~~~~~~~~~~
/home/kdm/projects/GISS/meli_pismupgrade/opt/include/pism/util/iceModelVec.hh:338:3: note:   candidate expects 4 arguments, 0 provided
/home/kdm/projects/GISS/meli_pismupgrade/src/icebin/slib/icebin/pism/IceCoupler_PISM.cpp: In member function ‘virtual void icebin::gpism::IceCoupler_PISM::ncread(ibmisc::NcIO&, const string&)’:
/home/kdm/projects/GISS/meli_pismupgrade/src/icebin/slib/icebin/pism/IceCoupler_PISM.cpp:60:11: error: call of overloaded ‘printf(const char [35], const char*)’ is ambiguous
   60 |     printf("BEGIN IceCoupler_PISM::ncread(%s)\n", vname_sheet.c_str());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/kdm/projects/GISS/meli_pismupgrade/opt/include/openmpi/ompi/mpi/cxx/mpicxx.h:50,
                 from /home/kdm/projects/GISS/meli_pismupgrade/opt/include/mpi.h:2658,
                 from /home/kdm/projects/GISS/meli_pismupgrade/src/icebin/slib/icebin/pism/IceCoupler_PISM.cpp:19:
/usr/include/stdio.h:356:12: note: candidate: ‘int printf(const char*, ...)’
  356 | extern int printf (const char *__restrict __format, ...);
      |            ^~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Icebin changes needed for latest PISM NASA-GISS/icebin
1 participant
@mankoff