Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating cookie consent component #1127

Merged
merged 40 commits into from
Sep 26, 2024
Merged

Creating cookie consent component #1127

merged 40 commits into from
Sep 26, 2024

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    8c62b28 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. cleaning up padding

    snmln committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    35f324f View commit details
    Browse the repository at this point in the history
  2. adjusting max width for poc

    snmln committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b57b33c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. creating modal exit animation

    snmln committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0e73df9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a49da2 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    eb03d75 View commit details
    Browse the repository at this point in the history
  2. creating core functionality

    snmln committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    e74f01a View commit details
    Browse the repository at this point in the history
  3. creating mobile styling

    snmln committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6d6695e View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    4714652 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1057a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e150e29 View commit details
    Browse the repository at this point in the history
  4. cleaning up layoutroot

    snmln committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    82ce544 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    16374be View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. creating unit test

    snmln committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1a6ad88 View commit details
    Browse the repository at this point in the history
  2. correcting Chrome bug

    snmln committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    322ab1c View commit details
    Browse the repository at this point in the history
  3. cleaning out comments

    snmln committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b77d334 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d4bd88d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    746f697 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. adding null check

    snmln committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    019ee97 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    33fb687 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1adb24a View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    e3b6966 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Implementing review feedback

    snmln committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b3b238f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    50029a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. implementing review feedback

    snmln committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    99170d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7267e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. implementing util classes

    snmln committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a030126 View commit details
    Browse the repository at this point in the history
  2. removing uneccessary comments

    snmln committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    11ee198 View commit details
    Browse the repository at this point in the history
  3. removing redundant util file

    snmln committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9cc346e View commit details
    Browse the repository at this point in the history
  4. remving .env check

    snmln committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    01b7443 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    84d3d62 View commit details
    Browse the repository at this point in the history
  2. Parse cookie consent form as html (#1163)

    **Related Ticket:** [_{link related ticket
    here}_](#1127)
    
    ### Description of Changes
    We already have a mechanism to parse markdown to html bts. It is highly
    likely that users will try to use different markdown syntax if they see
    the link syntax. So here, I made parcel resolver to compile the
    cookieconsent form to html beforehand. I only did it for copy, but some
    questions are
    - does title also accept markdown?
    - should we have some kinds of prefixes to note that this is a markdown?
    (we use ::markdown prefix for mdx files, but this is configuration so it
    can be a bit different story.
    hanbyul-here authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    51d6270 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    80f63a9 View commit details
    Browse the repository at this point in the history
  2. Remove custom styles, other small touch-ups, hide the cookie consent

    when close button is pressed
    hanbyul-here committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4ff71e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce5415e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b981fc View commit details
    Browse the repository at this point in the history
  5. correcting lint errors

    snmln committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    107ce35 View commit details
    Browse the repository at this point in the history
  6. Remove custom styles, other small touch-ups, hide the cookie consent …

    …when close btn is pressed (#1165)
    
    I removed some styles that are not necessary for cookieconsent. I will
    put my reasoning with inline comments.
    
    (Lots of changes are nitpicks, but I thought it might be a good
    opportunity to onboard you on some practices that are not well
    documented)
    snmln authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9b14371 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix Cookey Key

    hanbyul-here committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9356b87 View commit details
    Browse the repository at this point in the history
  2. Fix test

    hanbyul-here committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3bbd537 View commit details
    Browse the repository at this point in the history