-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for threading in cmeps #185
Conversation
Nuopc tests are failing with the latest CESM_nuopc_dev. I will try running with the master cime, cmeps, and cdeps. ERS_Vnuopc.T62_g16.CMOM_IAF.cheyenne_intel (Overall: FAIL) details: |
endif | ||
|
||
!$ call omp_set_num_threads(nthrds) | ||
print *,__FILE__,__LINE__,nthrds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These stray print statements need to be removed. There is also one in line 901
After switching to master cime, cmeps, and cdeps, The nuopc tests are now passing. Note that I get NLCOMP failures but I believe it has to do with new the namelist variable drv_threading. |
@@ -143,7 +144,8 @@ module MOM_cap_mod | |||
integer :: scalar_field_count = 0 | |||
integer :: scalar_field_idx_grid_nx = 0 | |||
integer :: scalar_field_idx_grid_ny = 0 | |||
character(len=*),parameter :: u_FILE_u = & | |||
integer :: nthrds !< number of openmp threads per task | |||
character(len=*),parameter :: u_file_u = & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, for consistency, we should change u_file_u
back to u_FILE_u
. (Not sure why it's changed in the first place.)
endif | ||
|
||
!$ call omp_set_num_threads(nthrds) | ||
print *,__FILE__,__LINE__,nthrds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove this print statement.
Thanks, @jedwards4b . Could you also remove the print statements. I'll then merge this and create a new tag. |
I did remove the print statements - are you looking at the latest code? |
MacOS CI fix + verbose builds on error
Add support for threading in cmeps driver.