Match ozone diagnostics to terms of the parametrization #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want the ozone tendency diagnostics to have the same units as each other (it looks like kg/kg here, presumably there's a step in the driver to accumulate these and divide by the interval of accumulation). I would also like each diagnostic to correspond to a single term in the parametrization, rather than one-and-a-half and then a different half.
DWesl
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
DWesl
changed the title
|
@DWesl This can be closed since ufs-community#196 exists. It'll be brought back to this fork by us code managers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed each diagnostic to correspond to a single term in the parametrization, rather than one-and-a-half and then the sum of all four.
That is, the first diagnostic of the old version was the first term of the parametrization plus the part of the second term that does not uses variables at the future time in the implicit update step (the$\left.\frac{d(P-L)}{dr}\right|_0 (r - r_0)$ term is implicit in $r_0$ part and excluded the $r(t+dt)$ part), and the second looked like the total photochemical tendency from the scheme, which the driver could accumulate on its own. In the new version, each diagnostic in
r; the first diagnostic included therun_o3prog_2015corresponds to a term of the equation in the documentation.