-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master update from dtc/develop 2019/12/17 #372
Merged
climbfuji
merged 59 commits into
NCAR:master
from
climbfuji:ncar_master_update_from_dtc_develop_20191217
Jan 6, 2020
Merged
master update from dtc/develop 2019/12/17 #372
climbfuji
merged 59 commits into
NCAR:master
from
climbfuji:ncar_master_update_from_dtc_develop_20191217
Jan 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gets used for all GWD schemes; remove drag_suite_pre,post; move some functionality from cires_ugwp_post to GFS_GWD_generic_post
…han hard-coded input.nml
Gmtb/develop
if(cplflx)then write(*,*)'Fatal error: CCPP not been tested with cplflx=true!' stop endif
update coupling
…h of namelist option for old/new ozphys and entry in suite definition file
…l/ccpp-physics into ozphys_guard_based_on_dtc_develop
CIRES UGWP namelist fix
…develop dtc/develop: prevent mismatch of namelist and suite definition file settings for ozone physics
modified: cires_ugwp_triggers.F90 modified: docs/ccpp_doxyfile modified: docs/library.bib new file: docs/pdftxt/UGWPv0.txt modified: docs/pdftxt/all_shemes_list.txt modified: ugwp_driver_v0.F
GWD interstitial reorganization
…shalcnv_post, add code to GFS_SCNV_generic_post instead
…idi.f; add guard to satmedmfvdif_init that checks for isatmedmf=0
…dmfvdifq (updated version of satmedmfvdif) and dependencies
…AFS version" to "updated version"
Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif)
…onding changes in interstitial and radiation code
…c_20191127 dtc/develop: update from EMC 2019/11/27
…P_generic_post_run from sfc_noahmp_pre; sfc_noahmp_pre no longer needed
…ccpp-physics into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
… into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
…l/ccpp-physics into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
…ntfirl/ccpp-physics into update_dtc_develop_from_emc_develop_and_collect_updates_20191205
Fix NoahMP precip rates
…c_develop_and_collect_updates_20191205 dtc/develop: collect updates to CCPP physics 2019/12/05
This was referenced Dec 18, 2019
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
December 20, 2019 02:57
llpcarson
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, approved.
grantfirl
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these changes look familiar from past work and reviews. Approved.
DusanJovic-NOAA
pushed a commit
to NOAA-EMC/fv3atm
that referenced
this pull request
Jan 10, 2020
* add new suite definition files for GFSv15p2, GFSv16beta * update existing suite definition files because of the interstitial code rearrangement (NCAR/ccpp-physics#372) * clean up CCPP compiler flags, add -Wall for GNU in DEBUG mode * add satmedmfvifq, shalcnv, sascnvn, Ferrier-Aligo microphysics and dependencies to CCPP prebuild config * bug fixes for ugwp and noahmp * move previous-timestep precipitation variables from Tbd to Sfcprop (as recommended by @HelinWei-NOAA, see NCAR/ccpp-physics#319) * fix compiler warnings about non-existent include directories * cleanup of old comments in GFS_physics_driver.F90 (see NCAR#4, NCAR#16, and NCAR/ccpp-physics#319 * CCPP annotations in GFS_driver.F90, GFS_radiation_driver.F90, GFS_physics_driver.F90 (comments that describe where code blocks ended up in the CCPP interstitial code) * capability to coldstart FV3 with GSD physics from RAP/HRRR initial conditions (required for FV3 SAR) * new suite definition file for coupled model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Associated PRs:
NOAA-EMC/GFDL_atmos_cubed_sphere#11
NCAR/ccpp-framework#246
#372
NOAA-EMC/fv3atm#30
ufs-community/ufs-weather-model#18
For regression testing, see ufs-community/ufs-weather-model#18.