Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action version updates: Node.js 16 actions are deprecated #478

Closed

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented May 22, 2024

Updating Github action versions that the CI is warning are or will be deprecated. Updating checkout to v4, setup-python to v5, cache to v4, upload-artifact to v4, setup-miniconda to v3.

Link to a run with lots of example warning messages that Node.js 16 actions are deprecated..

Tests Performed: the Github actions should run without any warnings.

Requires CCPP-Physics PR#1072

…ated. Checkout to v4, setup-python to v5, cache to v4, upload-artifact to v4, setup-miniconda to v3.
@scrasmussen scrasmussen force-pushed the update/github-action-versions branch from a7dc407 to 2f0478c Compare May 23, 2024 00:03
@RobertPincus
Copy link
Collaborator

See #480

@grantfirl
Copy link
Collaborator

@scrasmussen Can you revert the ccpp/physics submodule update for now? We will bring in the GF fix that'll fix the nvfortran tests from a ufs/dev PR. I don't want to do it out of order.

@grantfirl
Copy link
Collaborator

I'll approve once the ccpp-physics submodule pointer change is reverted.

@scrasmussen
Copy link
Member Author

I'll approve once the ccpp-physics submodule pointer change is reverted.

Hi @grantfirl , sorry I had missed these comments, in a meeting now but will remove the ccpp/physics commit in an hour

@scrasmussen
Copy link
Member Author

I'll approve once the ccpp-physics submodule pointer change is reverted.

Hi @grantfirl , sorry I had missed these comments, in a meeting now but will remove the ccpp/physics commit in an hour

Sorry was speed reading, looks like your commit fixed it? Will look closer after meeting

@grantfirl
Copy link
Collaborator

I'll approve once the ccpp-physics submodule pointer change is reverted.

Hi @grantfirl , sorry I had missed these comments, in a meeting now but will remove the ccpp/physics commit in an hour

Sorry was speed reading, looks like your commit fixed it? Will look closer after meeting

@scrasmussen Ya, I just pulled in the latest main and pointed to the latest main of ccpp-physics rather than the PR that fixes the openACC bug because it is coming in separately.

@grantfirl
Copy link
Collaborator

Combining with #486

@grantfirl grantfirl closed this Jun 6, 2024
@grantfirl grantfirl mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants